Bug 102537 - Computed grid items' positions shouldn't be using Length
Summary: Computed grid items' positions shouldn't be using Length
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2012-11-16 10:54 PST by Julien Chaffraix
Modified: 2012-11-19 08:40 PST (History)
10 users (show)

See Also:


Attachments
Proposed change: add GridPosition. (19.13 KB, patch)
2012-11-16 11:37 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-11-16 10:54:30 PST
Currently we convert grid-row and grid-column (resp. grid-row-position / grid-column-position in the latest spec) to Length inside StyleGridItemData:

// FIXME: For the moment, we only support a subset of the grammar which correspond to:
// 'auto' | <length>
// When we add more of the syntax, we will need a dedicated GridPosition class.
Length m_gridColumn;
Length m_gridRow;

(The comment is wrong, the grammar only allows <integer> not <length>)

Ojan pointed out in bug 102441 that it's confusing to use Length. The type was meant to be a temporary type to get the ball rolling so and it's probably time to kill this hack.
Comment 1 Julien Chaffraix 2012-11-16 11:37:33 PST
Created attachment 174729 [details]
Proposed change: add GridPosition.
Comment 2 Tony Chang 2012-11-16 13:13:52 PST
Comment on attachment 174729 [details]
Proposed change: add GridPosition.

LGTM
Comment 3 WebKit Review Bot 2012-11-19 08:40:17 PST
Comment on attachment 174729 [details]
Proposed change: add GridPosition.

Clearing flags on attachment: 174729

Committed r135164: <http://trac.webkit.org/changeset/135164>
Comment 4 WebKit Review Bot 2012-11-19 08:40:21 PST
All reviewed patches have been landed.  Closing bug.