Bug 102531 - [EFL][WK2] Web Inspector crashes if evas_gl is not available
Summary: [EFL][WK2] Web Inspector crashes if evas_gl is not available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-16 09:56 PST by Yael
Modified: 2012-11-19 13:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2012-11-16 10:00 PST, Yael 		kenneth: review+
Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2012-11-19 13:11 PST, Yael 		yael: commit-queue+
Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-11-19 13:16 PST, Yael 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-11-16 09:56:43 PST 
We need to teach Web Inspector to fallback gracefully to the software path when evas_gl engine is not available.
A patch is coming.
Comment 1 Yael 2012-11-16 10:00:14 PST 
Created attachment 174713 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-19 12:38:42 PST 
Comment on attachment 174713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93
> +    if (!m_inspectorWindow)

I would add comment here // Gracefully fall back to software if evas_gl engine is not available.
Comment 3 Yael 2012-11-19 13:11:49 PST 
Created attachment 175032 [details]
Patch

(In reply to comment #2)
> (From update of attachment 174713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review
> 
> > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93
> > +    if (!m_inspectorWindow)
> 
> I would add comment here // Gracefully fall back to software if evas_gl engine is not available.

Thank you for the review, I added the comment. I am not adding a warning as was done for the view, since Evas already gives a warning.
Comment 4 Yael 2012-11-19 13:16:34 PST 
Created attachment 175033 [details]
Patch

Forgot to update the reviewer name.
Comment 5 WebKit Review Bot 2012-11-19 13:48:21 PST 
Comment on attachment 175033 [details]
Patch

Clearing flags on attachment: 175033

Committed r135194: <http://trac.webkit.org/changeset/135194>
Comment 6 WebKit Review Bot 2012-11-19 13:48:26 PST 
All reviewed patches have been landed.  Closing bug.