Bug 102529 - [CSS Shaders] Remove the meshType from the CustomFilterOperations.
Summary: [CSS Shaders] Remove the meshType from the CustomFilterOperations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 101069 (view as bug list)
Depends on:
Blocks: 71392
  Show dependency tree / graph
 
Reported: 2012-11-16 09:48 PST by Alexandru Chiculita
Modified: 2013-04-25 16:05 PDT (History)
15 users (show)

See Also:

Attachments
Patch (6.60 KB, patch)
2013-04-02 02:03 PDT, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Patch (7.75 KB, patch)
2013-04-24 03:47 PDT, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-11-16 09:48:54 PST 
MeshType is already defined by the program, so remove the m_meshType from the CustomFilterOperations.
Comment 1 Qiankun Miao 2013-04-02 02:03:14 PDT 
Created attachment 196103 [details]
Patch
Comment 2 Early Warning System Bot 2013-04-02 02:08:45 PDT 
Comment on attachment 196103 [details]
Patch

Attachment 196103 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17361793
Comment 3 Early Warning System Bot 2013-04-02 02:09:34 PDT 
Comment on attachment 196103 [details]
Patch

Attachment 196103 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17332653
Comment 4 Michelangelo De Simone 2013-04-16 11:22:58 PDT 
This looks good, thanks for working on it.

If you need any help fixing this patch for Qt just let me know, I'll be most happy to help you.
Comment 5 Dean Jackson 2013-04-20 14:11:18 PDT 
Comment on attachment 196103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196103&action=review

> Source/WebCore/ChangeLog:11
> +        MeshType can be got from program, so remove the m_meshType related
> +        code in CustomFilterOperations.

Change "got" to "accessed"
Comment 6 Dean Jackson 2013-04-20 14:12:28 PDT 
This looks good. Should be a simple fix for QT and then I'll r+
Comment 7 Qiankun Miao 2013-04-24 03:47:39 PDT 
Created attachment 199410 [details]
Patch
Comment 8 Michelangelo De Simone 2013-04-25 15:34:09 PDT 
*** Bug 101069 has been marked as a duplicate of this bug. ***
Comment 9 Michelangelo De Simone 2013-04-25 15:39:14 PDT 
Thank you very much Qiankun, your help is sincerely appreciated.:)
Comment 10 WebKit Commit Bot 2013-04-25 16:05:30 PDT 
Comment on attachment 199410 [details]
Patch

Clearing flags on attachment: 199410

Committed r149153: <http://trac.webkit.org/changeset/149153>
Comment 11 WebKit Commit Bot 2013-04-25 16:05:35 PDT 
All reviewed patches have been landed.  Closing bug.