CSS Device Adaption tests expects the browser to use fixed layout. AFAIK all the ports don't enable this mode on WTR and we cannot enable this mode by default because it will break most of the baselines.
Created attachment 175161 [details] Patch
Adding more reviewers. At the bug 102811, I'm adding the same functionality for the Qt port, but it depends on the WK2 generic bits added by this patch.
Comment on attachment 175161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136 > +{ > + WKRetainPtr<WKStringRef> useFixedLayoutKey(AdoptWK, WKStringCreateWithUTF8CString("UseFixedLayout")); > + > + return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false); couldn't there not be other options that we don't support? How should we handle them? Shouldn't we check if there are other entries in the dictionary? and if so, return false?
Comment on attachment 175161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review >> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136 >> + return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false); > > couldn't there not be other options that we don't support? How should we handle them? > > Shouldn't we check if there are other entries in the dictionary? and if so, return false? Right now this is the only option supported. Prior to this patch, this code was an inline returning true for all platforms other than Mac.
Comment on attachment 175161 [details] Patch Clearing flag until I get a reply from Kenneth on the review.
Comment on attachment 175161 [details] Patch Clearing flags on attachment: 175161 Committed r135287: <http://trac.webkit.org/changeset/135287>
All reviewed patches have been landed. Closing bug.