Bug 102517 - [WTR] WebKitTestRunner should be able to run tests using fixed layout
Summary: [WTR] WebKitTestRunner should be able to run tests using fixed layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 95959 102811
  Show dependency treegraph
 
Reported: 2012-11-16 08:07 PST by Thiago Marcos P. Santos
Modified: 2012-11-20 09:15 PST (History)
8 users (show)

See Also:


Attachments
Patch (11.38 KB, patch)
2012-11-19 23:58 PST, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-11-16 08:07:36 PST
CSS Device Adaption tests expects the browser to use fixed layout. AFAIK all the ports don't enable this mode on WTR and we cannot enable this mode by default because it will break most of the baselines.
Comment 1 Thiago Marcos P. Santos 2012-11-19 23:58:06 PST
Created attachment 175161 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-11-20 06:59:43 PST
Adding more reviewers. At the bug 102811, I'm adding the same functionality for the Qt port, but it depends on the WK2 generic bits added by this patch.
Comment 3 Kenneth Rohde Christiansen 2012-11-20 08:01:24 PST
Comment on attachment 175161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136
> +{
> +    WKRetainPtr<WKStringRef> useFixedLayoutKey(AdoptWK, WKStringCreateWithUTF8CString("UseFixedLayout"));
> +
> +    return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false);

couldn't there not be other options that we don't support? How should we handle them?

Shouldn't we check if there are other entries in the dictionary? and if so, return false?
Comment 4 Thiago Marcos P. Santos 2012-11-20 08:10:42 PST
Comment on attachment 175161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review

>> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136
>> +    return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false);
> 
> couldn't there not be other options that we don't support? How should we handle them?
> 
> Shouldn't we check if there are other entries in the dictionary? and if so, return false?

Right now this is the only option supported. Prior to this patch, this code was an inline returning true for all platforms other than Mac.
Comment 5 Thiago Marcos P. Santos 2012-11-20 08:53:50 PST
Comment on attachment 175161 [details]
Patch

Clearing flag until I get a reply from Kenneth on the review.
Comment 6 WebKit Review Bot 2012-11-20 09:15:04 PST
Comment on attachment 175161 [details]
Patch

Clearing flags on attachment: 175161

Committed r135287: <http://trac.webkit.org/changeset/135287>
Comment 7 WebKit Review Bot 2012-11-20 09:15:09 PST
All reviewed patches have been landed.  Closing bug.