Bug 102516 – [BlackBerry] Enable Touch Sliders

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

Does as it says on the tin.

Created attachment 174687 [details]
Patch with changelog

[Rob Buis]

Comment on attachment 174687 [details]
Patch with changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=174687&action=review

Ok.

> ChangeLog:3
> +         Enable Touch Sliders

Next time please match the real bug title.

> Tools/ChangeLog:3
> +        Enable Touch Sliders

Ditto.

[Antonio Gomes]

Comment on attachment 174687 [details]
Patch with changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=174687&action=review

Does not it allow you to remove code in TouchEventHandler class?

> Tools/ChangeLog:8
> +        PR # 242781

I thought https://bugzilla.qnx.com/bugzilla/show_bug.cgi?id=176014 :)

Antonio - Yeah I sort of duped it internally.
Other code changes coming up separately.

[WebKit Review Bot]

Comment on attachment 174687 [details]
Patch with changelog

Rejecting attachment 174687 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/14845929

Created attachment 174700 [details]
Patch - WebKit

[Rob Buis]

Comment on attachment 174700 [details]
Patch - WebKit

LGTM.

[WebKit Review Bot]

Comment on attachment 174700 [details]
Patch - WebKit

Rejecting attachment 174700 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/14861274

[Rob Buis]

Created attachment 174859 [details]
Patch

[Rob Buis]

Comment on attachment 174859 [details]
Patch

Retrying

[WebKit Review Bot]

Comment on attachment 174859 [details]
Patch

Clearing flags on attachment: 174859

Committed r135088: <http://trac.webkit.org/changeset/135088>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.