We are planning to store more information about instrumented object in MemoryObjectInfo. It means that it will depend on other WTF classes(strings, collections etc.) but we don't want to include declarations of those classes into MemoryInstrumentation.h The solution is to move MemoryObjectInfo into its own header and make MemoryInstrumentation.h depend only on its forward declaration.
Created attachment 174692 [details] Patch
Attachment 174692 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1 Source/WTF/wtf/MemoryInstrumentation.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 174692 [details] Patch Attachment 174692 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14844943
Comment on attachment 174692 [details] Patch Attachment 174692 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14861241
Comment on attachment 174692 [details] Patch Attachment 174692 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14857700
Comment on attachment 174692 [details] Patch Attachment 174692 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14872353
Comment on attachment 174692 [details] Patch Attachment 174692 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14876131
Created attachment 174904 [details] Patch
Comment on attachment 174904 [details] Patch Attachment 174904 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14907097
Comment on attachment 174904 [details] Patch Attachment 174904 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14899093
Created attachment 174909 [details] Patch
Comment on attachment 174909 [details] Patch Attachment 174909 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14876856
Created attachment 174911 [details] Patch
Comment on attachment 174911 [details] Patch Attachment 174911 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14905117
Created attachment 174921 [details] Patch
(In reply to comment #15) > Created an attachment (id=174921) [details] > Patch Added WTF_EXPORT_PRIVATE to methods whose implementation moved to MemoryInstrumentation.cpp.
Comment on attachment 174921 [details] Patch Attachment 174921 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14904158
Created attachment 174968 [details] Patch
(In reply to comment #18) > Created an attachment (id=174968) [details] > Patch Added new symbols to JavaScriptCore.def to make patch compile on Windows.
Comment on attachment 174968 [details] Patch Attachment 174968 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14899240
gns@, could you help us understand what we are doing wrong in GTK build system, looking at the GNUmakefiles at seems that we have entries for MemoryInstrumentation.cpp in same places as for WTFString.cpp still Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp compiles fine while Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp doesn't link?
Committed r135603: <http://trac.webkit.org/changeset/135603>
(In reply to comment #22) > Committed r135603: <http://trac.webkit.org/changeset/135603> I filed a bug on the Gtk build error https://bugs.webkit.org/show_bug.cgi?id=103137 and removed MemoryInstrumentationTest.cpp from Tools/TestWebKitAPI/GNUmakefile.am until we resolve the issue.