RESOLVED FIXED 102487
[V8] Rename $className to $v8InterfaceName 
https://bugs.webkit.org/show_bug.cgi?id=102487
Summary [V8] Rename $className to $v8InterfaceName
Kentaro Hara
Reported 2012-11-16 05:30:16 PST
In CodeGeneratorV8.pm, $className is always "V8$interfaceName". We should rename $className to $v8InterfaceName. Also we can remove GetCallbackClassName().
Attachments
Patch (20.08 KB, patch)
2012-11-16 05:40 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (20.04 KB, patch)
2012-11-18 16:47 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-16 05:40:48 PST
Created attachment 174656 [details] Patch
WebKit Review Bot
Comment 2 2012-11-18 15:28:42 PST
Comment on attachment 174656 [details] Patch Rejecting attachment 174656 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: #29 succeeded at 3378 (offset -19 lines). Hunk #30 succeeded at 3461 (offset -19 lines). Hunk #31 succeeded at 3475 (offset -19 lines). Hunk #32 succeeded at 4214 (offset -19 lines). Hunk #33 succeeded at 4261 (offset -19 lines). 1 out of 33 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorV8.pm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14868954
Kentaro Hara
Comment 3 2012-11-18 16:47:06 PST
Created attachment 174862 [details] patch for landing
WebKit Review Bot
Comment 4 2012-11-18 17:12:50 PST
Comment on attachment 174862 [details] patch for landing Clearing flags on attachment: 174862 Committed r135092: <http://trac.webkit.org/changeset/135092>
WebKit Review Bot
Comment 5 2012-11-18 17:12:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.