Bug 102487 - [V8] Rename $className to $v8InterfaceName
Summary: [V8] Rename $className to $v8InterfaceName
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-16 05:30 PST by Kentaro Hara
Modified: 2012-11-18 17:12 PST (History)
3 users (show)

See Also:

Attachments
Patch (20.08 KB, patch)
2012-11-16 05:40 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (20.04 KB, patch)
2012-11-18 16:47 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-16 05:30:16 PST 
In CodeGeneratorV8.pm, $className is always "V8$interfaceName". We should rename $className to $v8InterfaceName. Also we can remove GetCallbackClassName().
Comment 1 Kentaro Hara 2012-11-16 05:40:48 PST 
Created attachment 174656 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-18 15:28:42 PST 
Comment on attachment 174656 [details]
Patch

Rejecting attachment 174656 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
#29 succeeded at 3378 (offset -19 lines).
Hunk #30 succeeded at 3461 (offset -19 lines).
Hunk #31 succeeded at 3475 (offset -19 lines).
Hunk #32 succeeded at 4214 (offset -19 lines).
Hunk #33 succeeded at 4261 (offset -19 lines).
1 out of 33 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorV8.pm.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14868954
Comment 3 Kentaro Hara 2012-11-18 16:47:06 PST 
Created attachment 174862 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-11-18 17:12:50 PST 
Comment on attachment 174862 [details]
patch for landing

Clearing flags on attachment: 174862

Committed r135092: <http://trac.webkit.org/changeset/135092>
Comment 5 WebKit Review Bot 2012-11-18 17:12:54 PST 
All reviewed patches have been landed.  Closing bug.