Bug 102470 – Web Inspector: don't show an Error when evaluating a watch expression results in an exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

See original report http://code.google.com/p/chromium/issues/detail?id=160440

When watch expression results in an exception it may make sense to say that its value is available in given context instead of showing exception that may confuse users in some cases e.g. when the expression references closure variable that has been optimized out.

[Yury Semikhatsky]

Created attachment 174623 [details]
Patch

[Yury Semikhatsky]

Created attachment 174624 [details]
Screenshot with the patch applied

[Yury Semikhatsky]

Created attachment 174625 [details]
Screenshot with the patch applied

Correct screenshot

[WebKit Review Bot]

Comment on attachment 174623 [details]
Patch

Attachment 174623 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14873052

New failing tests:
platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html
inspector/debugger/error-in-watch-expressions.html

[Vsevolod Vlasov]

Comment on attachment 174623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174623&action=review

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:394
> +        } else {

remove brackets

> Source/WebCore/inspector/front-end/inspector.css:-1651
> -.watch-expressions-error-level {

I'd keep it red.

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 174623 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174623&action=review
> 
> > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:394
> > +        } else {
> 
> remove brackets
> 
> > Source/WebCore/inspector/front-end/inspector.css:-1651
> > -.watch-expressions-error-level {
> 
> I'd keep it red.

It is still red, .watch-expressions-error-level was redundant as the value already has error marker in case of thrown exception.

[Yury Semikhatsky]

Committed r134928: <http://trac.webkit.org/changeset/134928>