Bug 102465 – [WK2] Bug on ASSERT code in CoordinatedBackingStore.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KyungTae Kim]

There's build error on Debug build on the ASSERT code in CoordinatedBackingStore.cpp (regression from https://bugs.webkit.org/show_bug.cgi?id=101023)
because the  ‘operator>=’ is not defined for WebCore::IntSize.

Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:52:105: error: no match for ‘operator>=’ in ‘textureMapper->WebCore::TextureMapper::maxTextureSize() >= std::max [with _Tp = int]((* &((WebKit::CoordinatedBackingStoreTile*)this)->WebKit::CoordinatedBackingStoreTile::m_tileRect.WebCore::IntRect::size().WebCore::IntSize::width()), (* &((WebKit::CoordinatedBackingStoreTile*)this)->WebKit::CoordinatedBackingStoreTile::m_tileRect.WebCore::IntRect::size().WebCore::IntSize::height()))’

[KyungTae Kim]

Created attachment 174613 [details]
Patch

[KyungTae Kim]

Created attachment 174616 [details]
Patch

[Daniel Bates]

Comment on attachment 174616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174616&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:52
> +    ASSERT(textureMapper->maxTextureSize().width() >= m_tileRect.size().width()  && textureMapper->maxTextureSize().height() >= m_tileRect.size().height());

Nit: There are two space characters before the "&&".

[KyungTae Kim]

Created attachment 174618 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 174618 [details]
Patch

Clearing flags on attachment: 174618

Committed r134912: <http://trac.webkit.org/changeset/134912>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Dongseong Hwang]

Thank you for fixing.

I really appreciate!