IndexedDB: convert delete-closed-database-object to upgradeneeded
Created attachment 174592 [details] Patch
Josh, you looked at this one the other day. My instinct is to land it as disabled in TestExpectations.
Any other thoughts or suggestions?
Comment on attachment 174592 [details] Patch Attachment 174592 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14843865 New failing tests: storage/indexeddb/delete-closed-database-object.html
Created attachment 174769 [details] Patch
I did some poking around and found the proximal cause (but not the root cause) - open(name, version) apparently leaks(?) the connection, whereas open(name) does not. So open(name)/setVersion(version) works fine. I uploaded a variant patch (as proof of concept) that does; db = open(name); // implicitly calls open(name, 1) behind the scenes db.close(); db = open(name); // open w/o version gc(); db = open(name, version); // no blocked event fired The patch I uploaded should be tweaked with a ChangeLog description and more evalAndLog() usage. We should also file a bug to track down the connection leak.
Created attachment 175048 [details] Patch
Josh, I added some evalAndLog calls to your patch. Could you take a look?
Comment on attachment 175048 [details] Patch lgtm - not sure why it's flaky in content_shell
Tony, could you review this?
Comment on attachment 175048 [details] Patch Clearing flags on attachment: 175048 Committed r135222: <http://trac.webkit.org/changeset/135222>
All reviewed patches have been landed. Closing bug.