Bug 102455 - IndexedDB: setVersion excision batch 9
Summary: IndexedDB: setVersion excision batch 9
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 18:55 PST by David Grogan
Modified: 2012-11-16 16:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (32.26 KB, patch)
2012-11-15 19:03 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (32.13 KB, patch)
2012-11-16 14:06 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-11-15 18:55:53 PST 
IndexedDB: setVersion excision batch 9
Comment 1 David Grogan 2012-11-15 19:03:03 PST 
Created attachment 174588 [details]
Patch
Comment 2 David Grogan 2012-11-15 19:05:23 PST 
Josh, could you take a look?  I think this is the last batch of regular tests.  The rest were broken in the conversion, were already disabled, or specifically test setversion.
Comment 3 Joshua Bell 2012-11-16 13:58:16 PST 
Comment on attachment 174588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174588&action=review

lgtm...

> LayoutTests/storage/indexeddb/resources/transaction-basics.js:228
> +//    trans.addEventListener('complete', completeCallback, false);

Delete this line?
Comment 4 David Grogan 2012-11-16 14:01:58 PST 
Comment on attachment 174588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174588&action=review

>> LayoutTests/storage/indexeddb/resources/transaction-basics.js:228
>> +//    trans.addEventListener('complete', completeCallback, false);
> 
> Delete this line?

Done.
Comment 5 David Grogan 2012-11-16 14:06:38 PST 
Created attachment 174756 [details]
Patch
Comment 6 David Grogan 2012-11-16 14:07:10 PST 
Tony, could you review this?
Comment 7 WebKit Review Bot 2012-11-16 16:03:48 PST 
Comment on attachment 174756 [details]
Patch

Rejecting attachment 174756 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ICT (content): Merge conflict in Source/WebKit2/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Source/WebKit/win: [WinCairo] Unreviewed build fix after r134960.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14847951
Comment 8 WebKit Review Bot 2012-11-16 16:53:03 PST 
Comment on attachment 174756 [details]
Patch

Clearing flags on attachment: 174756

Committed r135018: <http://trac.webkit.org/changeset/135018>
Comment 9 WebKit Review Bot 2012-11-16 16:53:07 PST 
All reviewed patches have been landed.  Closing bug.