Bug 102455 – IndexedDB: setVersion excision batch 9

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: setVersion excision batch 9

[David Grogan]

Created attachment 174588 [details]
Patch

[David Grogan]

Josh, could you take a look?  I think this is the last batch of regular tests.  The rest were broken in the conversion, were already disabled, or specifically test setversion.

[Joshua Bell]

Comment on attachment 174588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174588&action=review

lgtm...

> LayoutTests/storage/indexeddb/resources/transaction-basics.js:228
> +//    trans.addEventListener('complete', completeCallback, false);

Delete this line?

[David Grogan]

Comment on attachment 174588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174588&action=review

>> LayoutTests/storage/indexeddb/resources/transaction-basics.js:228
>> +//    trans.addEventListener('complete', completeCallback, false);
> 
> Delete this line?

Done.

[David Grogan]

Created attachment 174756 [details]
Patch

[David Grogan]

Tony, could you review this?

[WebKit Review Bot]

Comment on attachment 174756 [details]
Patch

Rejecting attachment 174756 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ICT (content): Merge conflict in Source/WebKit2/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Source/WebKit/win: [WinCairo] Unreviewed build fix after r134960.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14847951

[WebKit Review Bot]

Comment on attachment 174756 [details]
Patch

Clearing flags on attachment: 174756

Committed r135018: <http://trac.webkit.org/changeset/135018>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.