Bug 102438 – [Gtk] navigator.plugins contains too many plugin entries. First one are garbages

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[arno.]

Hi,
if I have 3 plugins, navigator.plugins.length will be 6
navigator.plugins[0], navigator.plugins[1] and navigator.plugins[2] will contain objets with null name, description or filename.
So, it looks like first half of navigator.plugins array contains wrong empty objects.

[arno.]

Created attachment 174534 [details]
Patch

patch proposal

[WebKit Review Bot]

Comment on attachment 174534 [details]
Patch

Attachment 174534 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14860009

New failing tests:
plugins/navigator-plugins.html

[Build Bot]

Comment on attachment 174534 [details]
Patch

Attachment 174534 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14858548

New failing tests:
plugins/navigator-plugins.html

[arno.]

Comment on attachment 174534 [details]
Patch

Of course, the test could only pass if the test system have the same number of plugins as me.

[arno.]

Created attachment 174763 [details]
Patch

updated patch

[Xan Lopez]

Comment on attachment 174763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174763&action=review

Looks good, r- with just a couple of minor comments.

> Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp:87
> +    outPlugins.resize(0);

If you look at PluginData::initPlugins() there's an ASSERT(m_plugins.isEmpty()) before calling this method, so I think we can just get rid of the resize(0) too, the vector will be empty always.

> LayoutTests/plugins/navigator-plugins.html:29
> +</body>

Hrm, it seems this could just be a pure js test in plugins/script-tests no? Look at navigator-mimeTypes-length.js for instance.

[arno.]

Created attachment 177530 [details]
Patch

updated patch

[Xan Lopez]

Comment on attachment 177530 [details]
Patch

Looks good to me, thanks.

[WebKit Review Bot]

Comment on attachment 177530 [details]
Patch

Clearing flags on attachment: 177530

Committed r136697: <http://trac.webkit.org/changeset/136697>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

The test added by this patch has been failing on Mac WebKit2:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=plugins%2Fnavigator-plugins.html

--- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/plugins/navigator-plugins-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/plugins/navigator-plugins-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS hasInvalidPlugin is false
+FAIL hasInvalidPlugin should be false. Was true.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryosuke Niwa]

Filed https://bugs.webkit.org/show_bug.cgi?id=105960 to track the test failure.