Bug 102434 – IndexedDB: setVersion batch 8

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: setVersion batch 8

[David Grogan]

Created attachment 174519 [details]
Patch

[David Grogan]

Josh, could you take a look?

After this patch there are 19 layout more tests that have setVersion warnings in their expected.txt.  There are a few more tests that have been disabled since before that warning was issued.  There are also a few setVersion instances in the chrome browser tests that need to be taken care of.

[Joshua Bell]

Comment on attachment 174519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174519&action=review

lgtm

> LayoutTests/ChangeLog:18
> +          Again awkward to call indexedDBTest all over the place. The prefix

We can delete removeVendorPrefixes() whenever we want now, right? (i.e. after the last batch is done)

> LayoutTests/ChangeLog:19
> +          line's gotta go, and we could also pull a resetDatabase method out of

How about simpleIndexedDBTest(upgradeNeededHandler, callback) that has onsuccess = { db.close(); callback(); }

> LayoutTests/ChangeLog:39
> +        * storage/indexeddb/resources/versionchangerequest-activedomobject.js:

I don't know if this is exercising the same code as before (the test looks like it's watching for a specific regression), but it seems fine.

[David Grogan]

Comment on attachment 174519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174519&action=review

>> LayoutTests/ChangeLog:18
>> +          Again awkward to call indexedDBTest all over the place. The prefix
> 
> We can delete removeVendorPrefixes() whenever we want now, right? (i.e. after the last batch is done)

I think we should keep the prefix check in until 24 goes to stable in the off chance that we want to open any of the layout tests in 23.  But we can remove its output via Quiet whenever.

>> LayoutTests/ChangeLog:19
>> +          line's gotta go, and we could also pull a resetDatabase method out of
> 
> How about simpleIndexedDBTest(upgradeNeededHandler, callback) that has onsuccess = { db.close(); callback(); }

That does seem promising.

[David Grogan]

Tony, could you review this?

[WebKit Review Bot]

Comment on attachment 174519 [details]
Patch

Clearing flags on attachment: 174519

Committed r134866: <http://trac.webkit.org/changeset/134866>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.