NEW102431
Bad style complaint about header in test file
https://bugs.webkit.org/show_bug.cgi?id=102431
Summary Bad style complaint about header in test file
Eric U.
Reported 2012-11-15 14:26:26 PST
Attachment 174514 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/tests/ChromeClientImplTest.cpp:35: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files Here are the headers: #include "config.h" #include <gtest/gtest.h> #include "Chrome.h" #include "WebFrameClient.h" #include "WebInputEvent.h" #include "WebView.h" #include "WebViewClient.h" #include "WebViewImpl.h" There is no "header this file implements", as this is a test file, so I'm not sure which part is really confusing it. Line 35 is the #include of "Chrome.h".
Attachments
Note You need to log in before you can comment on or make changes to this bug.