Bug 102426 – Ignore autocomplete=off for chrome generated passwords.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yue Zhang]

Ignore autocomplete=off for chrome generated passwords.

[Yue Zhang]

Created attachment 174510 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 174510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174510&action=review

> Source/WebKit/chromium/public/WebPasswordFormData.h:101
> +    // Value of shouldAutocomplete for the password element.
> +    bool passwordShouldAutocomplete;

Can you add an inline constructor that initializes this value to something?

[Yue Zhang]

Created attachment 174518 [details]
Patch

[Adam Barth]

Comment on attachment 174518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174518&action=review

> Source/WebKit/chromium/public/WebPasswordFormData.h:110
> +    WebPasswordFormData(): passwordShouldAutocomplete(false) { }

This isn't in quite the right style.  The appropriate style is as follows:

WebPasswordFormData()
    : passwordShouldAutocomplete(false)
{
}

[Yue Zhang]

Created attachment 174521 [details]
Patch

[WebKit Review Bot]

Attachment 174521 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/public/WebPasswordFormData.h:111:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 174521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174521&action=review

>> Source/WebKit/chromium/public/WebPasswordFormData.h:111
>> +      : passwordShouldAutocomplete(false)
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Yeah, you need two more spaces.

[Yue Zhang]

Created attachment 174522 [details]
Patch

[Adam Barth]

Comment on attachment 174522 [details]
Patch

Yay!  Thanks!  :)

[WebKit Review Bot]

Comment on attachment 174522 [details]
Patch

Clearing flags on attachment: 174522

Committed r134852: <http://trac.webkit.org/changeset/134852>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.