Bug 102422 - Add setChecked API in WebInputElement
Summary: Add setChecked API in WebInputElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 13:04 PST by Raman Kumar
Modified: 2012-11-16 16:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2012-11-16 12:29 PST, Raman Kumar 		no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2012-11-16 14:32 PST, Raman Kumar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raman Kumar 2012-11-15 13:04:13 PST 
WebInputElement doesn't expose the underlying HTMLInputElement's setCheckout API. This is required to enable chromium to check a checkbox element.
Comment 1 Raman Kumar 2012-11-16 12:29:09 PST 
Created attachment 174742 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-16 12:36:03 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-11-16 12:38:44 PST 
Comment on attachment 174742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please fill out this part of the ChangeLog.

> Source/WebKit/chromium/public/WebInputElement.h:77
> +        WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);

Can we use an enum for the second parameter rather than a raw boolean?  It looks like HTMLInputElement already uses an enum.
Comment 4 Raman Kumar 2012-11-16 14:32:17 PST 
Created attachment 174761 [details]
Patch
Comment 5 Raman Kumar 2012-11-16 14:39:26 PST 
Comment on attachment 174742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review

>> Source/WebKit/chromium/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Please fill out this part of the ChangeLog.

Done. Sorry for that, this is my first CL in webkit, still figuring out the process.

>> Source/WebKit/chromium/public/WebInputElement.h:77
>> +        WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);
> 
> Can we use an enum for the second parameter rather than a raw boolean?  It looks like HTMLInputElement already uses an enum.

This change is consistent with setValue(), HTMLInputElement's setValue also uses same enum. I don't exactly understand why bool was preferred here earlier, assuming there is a reason, I am trying to be consistent.
Comment 6 Adam Barth 2012-11-16 14:47:27 PST 
Comment on attachment 174761 [details]
Patch

ok
Comment 7 WebKit Review Bot 2012-11-16 16:32:03 PST 
Comment on attachment 174761 [details]
Patch

Clearing flags on attachment: 174761

Committed r135016: <http://trac.webkit.org/changeset/135016>
Comment 8 WebKit Review Bot 2012-11-16 16:32:07 PST 
All reviewed patches have been landed.  Closing bug.