Bug 102417 – REGRESSION(r134800): This patch broke chromium port (Requested by jianli on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/134800 broke the build:
This patch broke chromium port (Requested by jianli on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 174494 [details]
ROLLOUT of r134800

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Jian Li]

FYI, here is the bot output:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/31230/steps/compile/logs/stdio

It seems that you need to figure out how to land 2-side changes correctly.

[WebKit Review Bot]

Comment on attachment 174494 [details]
ROLLOUT of r134800

Clearing flags on attachment: 174494

Committed r134810: <http://trac.webkit.org/changeset/134810>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tommy Widenflycht]

(In reply to comment #2)
> FYI, here is the bot output:
> http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/31230/steps/compile/logs/stdio
> 
> It seems that you need to figure out how to land 2-side changes correctly.

I know how to do that, what I don't know how to do it seems is to build everything locally. I was completely unaware that someone had overridden WebRTCPeerConnectionHandlerClient in a mock but I have now updated my build script to build the relavant unit test targets as well.

Sorry for wasting your time!