Bug 102409 - Text Autosizing: Improve handling of nested comments on reddit.com
Summary: Text Autosizing: Improve handling of nested comments on reddit.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: John Mellor
URL: http://www.reddit.com/r/AskReddit/com...
Keywords:
Depends on: 105188
Blocks: FontBoosting 102408
  Show dependency tree / graph
 
Reported: 2012-11-15 10:08 PST by John Mellor
Modified: 2019-05-02 10:36 PDT (History)
10 users (show)

See Also:

Attachments
Screenshot of reddit.com comments (176.68 KB, image/png)
2012-11-15 10:08 PST, John Mellor 		no flags Details
Patch (6.34 KB, patch)
2012-11-22 07:48 PST, John Mellor 		no flags Details | Formatted Diff | Diff
Screenshot of reddit.com comments with patch applied (229.93 KB, image/png)
2012-11-22 07:51 PST, John Mellor 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Mellor 2012-11-15 10:08:04 PST 
Created attachment 174475 [details]
Screenshot of reddit.com comments

Text Autosizing poorly handles the nested comment threads on reddit.com.

See attached screenshot - ideally the comments would all share the same font size.

This is similar to bug 102408, but on reddit.com the comments are forming clusters (see bug 97025) due to overflow:hidden and overflow:auto styles, rather than because they're wrapped in table cells.
Comment 1 John Mellor 2012-11-22 07:48:33 PST 
Created attachment 175673 [details]
Patch
Comment 2 John Mellor 2012-11-22 07:51:42 PST 
Created attachment 175675 [details]
Screenshot of reddit.com comments with patch applied

This is how reddit.com comments look with the new patch (i.e. their size is homogenous).
Comment 3 Kenneth Rohde Christiansen 2012-11-22 07:54:32 PST 
Comment on attachment 175673 [details]
Patch

Nice, definitely looks better!
Comment 4 WebKit Review Bot 2012-11-22 18:54:53 PST 
Comment on attachment 175673 [details]
Patch

Clearing flags on attachment: 175673

Committed r135553: <http://trac.webkit.org/changeset/135553>
Comment 5 WebKit Review Bot 2012-11-22 18:54:57 PST 
All reviewed patches have been landed.  Closing bug.