Bug 102407 - [V8] We shouldn't call deprecated V8 APIs
Summary: [V8] We shouldn't call deprecated V8 APIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 09:55 PST by Adam Barth
Modified: 2012-11-15 12:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.43 KB, patch)
2012-11-15 09:56 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (15.54 KB, patch)
2012-11-15 09:59 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-15 09:55:33 PST 
[V8] We shouldn't call deprecated V8 APIs
Comment 1 Adam Barth 2012-11-15 09:56:55 PST 
Created attachment 174472 [details]
Patch
Comment 2 Adam Barth 2012-11-15 09:59:03 PST 
The ScriptProfiler code was added in http://trac.webkit.org/changeset/112861 by yurys and pfeldman.
Comment 3 Adam Barth 2012-11-15 09:59:24 PST 
Created attachment 174473 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-11-15 10:25:12 PST 
Comment on attachment 174473 [details]
Patch

rs=me.
Comment 5 Adam Barth 2012-11-15 11:30:13 PST 
Comment on attachment 174473 [details]
Patch

The test added in http://trac.webkit.org/changeset/112861 seems to pass with this change.  Given that the current code doesn't make much sense, I'm inclined to land this patch.

Please let me know if we need to iterate on the ScriptProfiler.cpp part of the change.
Comment 6 WebKit Review Bot 2012-11-15 12:01:54 PST 
Comment on attachment 174473 [details]
Patch

Clearing flags on attachment: 174473

Committed r134811: <http://trac.webkit.org/changeset/134811>
Comment 7 WebKit Review Bot 2012-11-15 12:01:58 PST 
All reviewed patches have been landed.  Closing bug.