Bug 102401 – Move natural sorting to a separate module

• Status: NEW
• Component: New Bugs

[Zan Dobersek]

Move natural sorting to a separate module

[Zan Dobersek]

Created attachment 174468 [details]
Patch

[Zan Dobersek]

Continuing from bug 102229:

> (In reply to comment #2)
> > (From update of attachment 174186 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=174186&action=review
> > 
> > The patch adds two new modules under webkitpy.common. The natural_order (could use a better name) contains methods for natural sorting and test key that were moved here from the Sharder class. The test_name method contains the TEST_PATH_SEPARATOR variable and the split_test_name method, both moved here from the Port class.
> > 
> 
> What do you not like about "natural_order" as a name?

I guess it's OK, I was also pondering names like natural_sort, natural_sorting or natura_ordering even. I'm OK with any of those.

[Dirk Pranke]

Comment on attachment 174468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174468&action=review

> Tools/Scripts/webkitpy/common/natural_order.py:34
> +def _natural_sort_key(string_to_split):

If we're going to split natural_sort into a separate module, it should *only* deal with natural sorting, and not have anything to do with "test_name"s at all. Also, depending on how the rest of this code shakes out, it might be that we can move the natural_sort code into port/base.py for now (until we move all of the test-handling logic out) and avoid needing to reference things from three different modules.

[Zan Dobersek]

Created attachment 175949 [details]
Patch

[Dirk Pranke]

Comment on attachment 175949 [details]
Patch

I'm pretty sure this patch is no longer needed and won't even apply. Let me take a look, and, if I'm wrong, I'll re-cq+ it.