Bug 102397 - [BlackBerry] Fix suspend/resume assertion in setCompositor()
Summary: [BlackBerry] Fix suspend/resume assertion in setCompositor()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 09:00 PST by Jakob Petsovits
Modified: 2012-11-15 09:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.04 KB, patch)
2012-11-15 09:03 PST, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-11-15 09:00:06 PST 
If a compositor is used but no surface pool is ever allocated (which is a perfectly valid use case), initial suspension of the backingstore is skipped because of an early return. This will cause an assertion to be triggered and a bug. Fix this by suspending it before the return.

With Adam Treat's recent change to split suspension of screen and backingstore into two different functions, this can now be reduced to a mere screen (blitting) suspension. That was the original intention of this code.
Comment 1 Jakob Petsovits 2012-11-15 09:03:26 PST 
Created attachment 174459 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-15 09:58:17 PST 
Comment on attachment 174459 [details]
Patch

Clearing flags on attachment: 174459

Committed r134788: <http://trac.webkit.org/changeset/134788>
Comment 3 WebKit Review Bot 2012-11-15 09:58:20 PST 
All reviewed patches have been landed.  Closing bug.