Bug 102386 - [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
Summary: [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::di...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-11-15 07:07 PST by Tommy Widenflycht
Modified: 2012-11-16 10:40 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.56 KB, patch)
2012-11-15 08:35 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2012-11-16 01:51 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-11-15 07:07:27 PST 
[chromium] MediaStreamAPI: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
Comment 1 Tommy Widenflycht 2012-11-15 08:35:46 PST 
Created attachment 174454 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-15 08:39:54 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-11-15 10:38:49 PST 
Comment on attachment 174454 [details]
Patch

ok
Comment 4 WebKit Review Bot 2012-11-15 11:23:24 PST 
Comment on attachment 174454 [details]
Patch

Clearing flags on attachment: 174454

Committed r134805: <http://trac.webkit.org/changeset/134805>
Comment 5 WebKit Review Bot 2012-11-15 11:23:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Tommy Widenflycht 2012-11-16 01:26:15 PST 
Patch broke chromium build.
Comment 7 Tommy Widenflycht 2012-11-16 01:51:59 PST 
Created attachment 174632 [details]
Patch
Comment 8 Tommy Widenflycht 2012-11-16 01:52:22 PST 
This patch just differs from the previous one in that the new method in WebRTCPeerConnectionHandlerClient now has an default implementation instead of being pure virtual.
Comment 9 WebKit Review Bot 2012-11-16 10:40:04 PST 
Comment on attachment 174632 [details]
Patch

Clearing flags on attachment: 174632

Committed r134970: <http://trac.webkit.org/changeset/134970>
Comment 10 WebKit Review Bot 2012-11-16 10:40:07 PST 
All reviewed patches have been landed.  Closing bug.