Bug 102384 - Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
Summary: Memory instrumentation: add code for reporting stack traces of unknown instru...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 06:55 PST by Yury Semikhatsky
Modified: 2012-11-15 23:30 PST (History)
14 users (show)

See Also:


Attachments
Patch (7.52 KB, patch)
2012-11-15 07:09 PST, Yury Semikhatsky
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.50 KB, patch)
2012-11-15 08:25 PST, Yury Semikhatsky
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (9.11 KB, patch)
2012-11-15 22:45 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-11-15 06:55:10 PST
Would be convenient to have a code that would report stack traces for objects that are reported to the memory instrumentation but are not among the objects allocated by malloc.
Comment 1 Yury Semikhatsky 2012-11-15 07:09:53 PST
Created attachment 174431 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-15 07:13:59 PST
Attachment 174431 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-11-15 07:43:55 PST
Comment on attachment 174431 [details]
Patch

Rejecting attachment 174431 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
st.cpp:93: error: conflicting return type specified for 'virtual void<unnamed>::MemoryInstrumentationTestClient::checkCountedObject(const void*)'
Source/WTF/wtf/MemoryInstrumentation.h:102: error:   overriding 'virtual bool WTF::MemoryInstrumentationClient::checkCountedObject(const void*)'
make: *** [out/Release/obj.target/TestWebKitAPI/Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.o] Error 1
make: *** Waiting for unfinished jobs....
  LINK(target) out/Release/DumpRenderTree: Finished

Full output: http://queues.webkit.org/results/14857241
Comment 4 EFL EWS Bot 2012-11-15 07:57:41 PST
Comment on attachment 174431 [details]
Patch

Attachment 174431 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14843614
Comment 5 WebKit Review Bot 2012-11-15 08:00:26 PST
Comment on attachment 174431 [details]
Patch

Attachment 174431 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14846425
Comment 6 Yury Semikhatsky 2012-11-15 08:25:31 PST
Created attachment 174450 [details]
Patch for landing

Fixed Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp compilation.
Comment 7 WebKit Review Bot 2012-11-15 08:27:16 PST
Attachment 174450 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2012-11-15 09:09:18 PST
Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14833763
Comment 9 EFL EWS Bot 2012-11-15 10:18:09 PST
Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14843664
Comment 10 kov's GTK+ EWS bot 2012-11-15 12:42:32 PST
Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14846524
Comment 11 Peter Beverloo (cr-android ews) 2012-11-15 14:24:40 PST
Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14847511
Comment 12 Build Bot 2012-11-15 22:38:06 PST
Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14861070
Comment 13 Yury Semikhatsky 2012-11-15 22:45:17 PST
Created attachment 174610 [details]
Patch for landing
Comment 14 WebKit Review Bot 2012-11-15 22:48:29 PST
Attachment 174610 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Yury Semikhatsky 2012-11-15 23:30:41 PST
Committed r134906: <http://trac.webkit.org/changeset/134906>