Bug 102384 – Memory instrumentation: add code for reporting stack traces of unknown instrumented objects

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Would be convenient to have a code that would report stack traces for objects that are reported to the memory instrumentation but are not among the objects allocated by malloc.

[Yury Semikhatsky]

Created attachment 174431 [details]
Patch

[WebKit Review Bot]

Attachment 174431 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 174431 [details]
Patch

Rejecting attachment 174431 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
st.cpp:93: error: conflicting return type specified for 'virtual void<unnamed>::MemoryInstrumentationTestClient::checkCountedObject(const void*)'
Source/WTF/wtf/MemoryInstrumentation.h:102: error:   overriding 'virtual bool WTF::MemoryInstrumentationClient::checkCountedObject(const void*)'
make: *** [out/Release/obj.target/TestWebKitAPI/Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.o] Error 1
make: *** Waiting for unfinished jobs....
  LINK(target) out/Release/DumpRenderTree: Finished

Full output: http://queues.webkit.org/results/14857241

[EFL EWS Bot]

Comment on attachment 174431 [details]
Patch

Attachment 174431 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14843614

[WebKit Review Bot]

Comment on attachment 174431 [details]
Patch

Attachment 174431 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14846425

[Yury Semikhatsky]

Created attachment 174450 [details]
Patch for landing

Fixed Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp compilation.

[WebKit Review Bot]

Attachment 174450 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14833763

[EFL EWS Bot]

Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14843664

[kov's GTK+ EWS bot]

Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14846524

[Peter Beverloo (cr-android ews)]

Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14847511

[Build Bot]

Comment on attachment 174450 [details]
Patch for landing

Attachment 174450 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14861070

[Yury Semikhatsky]

Created attachment 174610 [details]
Patch for landing

[WebKit Review Bot]

Attachment 174610 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Me..." exit_code: 1
Source/WTF/wtf/MemoryInstrumentation.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Committed r134906: <http://trac.webkit.org/changeset/134906>