RESOLVED FIXED102380
Web Inspector: http/tests/inspector/stacktraces/* are flakey in JSC
https://bugs.webkit.org/show_bug.cgi?id=102380
Summary Web Inspector: http/tests/inspector/stacktraces/* are flakey in JSC
Mike West
Reported 2012-11-15 06:38:53 PST
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showExpectations=true&tests=http%2Ftests%2Finspector%2Fstacktraces%2F shows the story. Half the time the trace looks like: 0) http://127.0.0.1:8000/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html / thisTest / 12 / 0 1) (internal script) / eval code / (line number) / (column number) 2) [native code] / eval / 0 / 0 3) [native code] / evaluate / 0 / 0 4) (internal script) / _evaluateOn / (line number) / (column number) 5) (internal script) / _evaluateAndWrap / (line number) / (column number) 6) (internal script) / evaluate / (line number) / (column number) The other half, it looks like this: 0) http://127.0.0.1:8000/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html / thisTest / 12 / 0 1) (internal script) / eval code / (line number) / (column number) 2) [native code] / eval / 0 / 0 3) [native code] / evaluate / 0 / 0 4) [native code] / call / 0 / 0 5) (internal script) / _evaluateOn / (line number) / (column number) 6) (internal script) / _evaluateAndWrap / (line number) / (column number) 7) (internal script) / evaluate / (line number) / (column number) The traces are identical, except for line 4. I'm not sure why this happens; I'm tempted to change the test to only check the top frame of the trace.
Attachments
Patch (14.36 KB, patch)
2012-11-15 06:54 PST, Mike West
no flags
Grrr. (13.79 KB, patch)
2012-11-16 05:10 PST, Mike West
no flags
Mike West
Comment 1 2012-11-15 06:54:10 PST
Mike West
Comment 2 2012-11-16 05:10:55 PST
WebKit Review Bot
Comment 3 2012-11-16 06:59:18 PST
Comment on attachment 174649 [details] Grrr. Attachment 174649 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14868192 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Mike West
Comment 4 2012-11-17 01:56:01 PST
Comment on attachment 174649 [details] Grrr. The failure looks unrelated, and doesn't reproduce locally. I'll land it; if it dies on the main waterfall, I'll roll it out.
WebKit Review Bot
Comment 5 2012-11-17 02:27:13 PST
Comment on attachment 174649 [details] Grrr. Clearing flags on attachment: 174649 Committed r135042: <http://trac.webkit.org/changeset/135042>
WebKit Review Bot
Comment 6 2012-11-17 02:27:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.