Bug 102354 – Avoid copying of ViewportArguments in computeViewportAttributes function

• Status: REOPENED
• Component: WebCore Misc.

[Mikhail Pozdnyakov]

Since r134749 we do not need copying of ViewportArguments parameter in computeViewportAttributes() as we're not modifying it any more.

[Mikhail Pozdnyakov]

Created attachment 174372 [details]
patch

[Kenneth Rohde Christiansen]

Are you sure you dont need to change export symbols?

[Build Bot]

Comment on attachment 174372 [details]
patch

Attachment 174372 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14832765

[Mikhail Pozdnyakov]

Created attachment 174411 [details]
run EWS (don't put any flags)

[Build Bot]

Comment on attachment 174411 [details]
run EWS (don't put any flags)

Attachment 174411 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14838698

[Mikhail Pozdnyakov]

Created attachment 174420 [details]
patch v3

Now bots shall be glad.

[WebKit Review Bot]

Comment on attachment 174420 [details]
patch v3

Clearing flags on attachment: 174420

Committed r134908: <http://trac.webkit.org/changeset/134908>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 102472

[Daniel Bates]

(In reply to comment #9)
> Re-opened since this is blocked by bug 102472

This change broke the Apple Windows Debug build:

12>   Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.exp
12>WebCoreTestSupport.lib(InternalSettings.obj) : error LNK2019: unresolved external symbol "struct WebCore::ViewportAttributes __cdecl WebCore::computeViewportAttributes(struct WebCore::ViewportArguments,int,int,int,float,class WebCore::IntSize)" (?computeViewportAttributes@WebCore@@YA?AUViewportAttributes@1@UViewportArguments@1@HHHMVIntSize@1@@Z) referenced in function "public: class WTF::String __thiscall WebCore::InternalSettings::configurationForViewport(float,int,int,int,int,int &)" (?configurationForViewport@InternalSettings@WebCore@@QAE?AVString@WTF@@MHHHHAAH@Z)

<http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/58041/steps/compile-webkit/logs/stdio>

After discussing this issue with Mikhail Pozdnyakov on IRC this morning, we decided to rollout this change so as to fix it offline.

[Daniel Bates]

(In reply to comment #9)
> Re-opened since this is blocked by bug 102472

For completeness, I tried to fix the build in <http://trac.webkit.org/changeset/134913>, but it didn't work out :( I reverted this attempt in the patch for bug #102472.

[Mikhail Pozdnyakov]

(In reply to comment #11)
> (In reply to comment #9)
> > Re-opened since this is blocked by bug 102472
> 
> For completeness, I tried to fix the build in <http://trac.webkit.org/changeset/134913>, but it didn't work out :( I reverted this attempt in the patch for bug #102472.

I've carefully checked exported symbols and did not find any reason it should cause build failure (all .def files are updated), logs say:
unresolved external symbol "struct WebCore::ViewportAttributes __cdecl WebCore::computeViewportAttributes(struct WebCore::ViewportArguments,int,int,int,float,class WebCore::IntSize)

which does not exist already, so I suppose the problem could have been solved by clean build triggering.

[Eric Seidel (no email)]

Comment on attachment 174372 [details]
patch

Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 174372 [details] so that this bug does not appear in http://webkit.org/pending-commit.