Bug 102348 – [V8] Remove IsSubType() from CodeGeneratorV8.pm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

CodeGenerator.pm has IsStrictSubType(). CodeGeneratorV8.pm should use it.

[Kentaro Hara]

Created attachment 174367 [details]
Patch

[Adam Barth]

Comment on attachment 174367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174367&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1422
> -    my $eventTarget = $dataNode->extendedAttributes->{"EventTarget"} || $codeGenerator->IsStrictSubtype($dataNode, "EventTarget");
> +    my $eventTarget = $dataNode->extendedAttributes->{"EventTarget"} || $codeGenerator->IsStrictSubType($dataNode, "EventTarget");

Why not change this to call IsSubType since it's using that pattern anyway?

[Kentaro Hara]

Created attachment 174551 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 174551 [details]
patch for landing

Rejecting attachment 174551 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 #10 succeeded at 1250 (offset 1 line).
Hunk #11 succeeded at 1309 (offset 1 line).
Hunk #12 succeeded at 1562 (offset 1 line).
Hunk #13 succeeded at 2509 (offset 1 line).
Hunk #14 succeeded at 3496 (offset 1 line).
Hunk #15 succeeded at 3513 (offset 1 line).
1 out of 15 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorV8.pm.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14848580

[Kentaro Hara]

Created attachment 174581 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 174581 [details]
patch for landing

Clearing flags on attachment: 174581

Committed r134881: <http://trac.webkit.org/changeset/134881>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #6)
> (From update of attachment 174581 [details])
> Clearing flags on attachment: 174581
> 
> Committed r134881: <http://trac.webkit.org/changeset/134881>

It broke http/tests/appcache tests on JSC platforms:
- EFL: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/216
- Qt: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/54634

[Kentaro Hara]

(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 174581 [details] [details])
> > Clearing flags on attachment: 174581
> > 
> > Committed r134881: <http://trac.webkit.org/changeset/134881>
> 
> It broke http/tests/appcache tests on JSC platforms:
> - EFL: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/216
> - Qt: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/54634

hmm... I don't think the patch causes the failure. Either way now I'm looking into another failure and have no time to fix it. Let me revert the patch.

[Csaba Osztrogonác]

I'm sure if it is the culprit. 

- r134880 - http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20NRWT/builds/23663
- r134881 - http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20NRWT/builds/23664

[Kentaro Hara]

Reverted r134881 for reason:

http/tests/appcache tests on JSC platforms are broken

Committed r134893: <http://trac.webkit.org/changeset/134893>

[Kentaro Hara]

Thanks! For now reverted the culprit. Will take a detailed look later.

[Kentaro Hara]

Created attachment 174651 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 174651 [details]
patch for landing

Clearing flags on attachment: 174651

Committed r134940: <http://trac.webkit.org/changeset/134940>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.