UNCONFIRMED 102346
Fix incomplete holding lock on accessing m_completeDatabasePath 
https://bugs.webkit.org/show_bug.cgi?id=102346
Summary Fix incomplete holding lock on accessing m_completeDatabasePath
Changhyup Jwa
Reported 2012-11-15 00:27:58 PST
Holding m_syncLock is required on accessing m_completeDatabasePath, but there're several lines not holding it. So, we should hold m_syncLock whenever we access to m_completeDatabasePath.
Attachments
Patch (5.60 KB, patch)
2012-11-15 00:41 PST, Changhyup Jwa 		no flags
DetailsFormatted DiffDiff
Patch (5.59 KB, patch)
2012-11-15 22:31 PST, Changhyup Jwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Changhyup Jwa
Comment 1 2012-11-15 00:41:26 PST
Created attachment 174366 [details] Patch
WebKit Review Bot
Comment 2 2012-11-15 01:23:03 PST
Comment on attachment 174366 [details] Patch Attachment 174366 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14838628 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Gyuyoung Kim
Comment 3 2012-11-15 03:05:35 PST
Comment on attachment 174366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174366&action=review > Source/WebCore/ChangeLog:10 > + holding m_syncLock. Any test case ?
Changhyup Jwa
Comment 4 2012-11-15 03:58:08 PST
Comment on attachment 174366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174366&action=review >> Source/WebCore/ChangeLog:10 >> + holding m_syncLock. > > Any test case ? There's no change on WebKit's functionality on this patch, I just move the lines inside mutex lock(hold m_syncLock). m_completeDatabasePath is a shared resource between the 2 threads(main and IconDatabase::iconDatabaseSyncThread). So, it should be accessed with holding m_syncLock. But below lines are accessing m_completeDatabasePath without holding this. Therefore I just modified those lines with holding m_syncLock, with no functional change.
Changhyup Jwa
Comment 5 2012-11-15 22:31:58 PST
Created attachment 174609 [details] Patch
Changhyup Jwa
Comment 6 2012-11-20 23:13:20 PST
I'm making a TC for this patch
Anders Carlsson
Comment 7 2014-02-05 11:05:49 PST
Comment on attachment 174609 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.