Bug 102343 - Remove coneGain and distanceGain attributes from PannerNode.idl
Summary: Remove coneGain and distanceGain attributes from PannerNode.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Li Yin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 23:42 PST by Li Yin
Modified: 2012-11-17 12:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2012-11-14 23:47 PST, Li Yin 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2012-11-16 22:20 PST, Li Yin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li Yin 2012-11-14 23:42:44 PST 
Removing .coneGain and .distanceGain as publicly accessible values, since normally they only need to be calculated internally.
Comment 1 Li Yin 2012-11-14 23:47:41 PST 
Created attachment 174362 [details]
Patch
Comment 2 Chris Rogers 2012-11-16 10:30:15 PST 
Comment on attachment 174362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review

Li, thanks this looks good with minor nit.

> Source/WebCore/ChangeLog:11
> +        No new tests. No change in functionality.

This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed."
Comment 3 Li Yin 2012-11-16 22:20:00 PST 
Created attachment 174807 [details]
Patch
Comment 4 Li Yin 2012-11-16 22:20:58 PST 
(In reply to comment #2)
> (From update of attachment 174362 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review
> 
> Li, thanks this looks good with minor nit.
> 
> > Source/WebCore/ChangeLog:11
> > +        No new tests. No change in functionality.
> 
> This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed."

Done.

Thanks for your comments.
Comment 5 Chris Rogers 2012-11-17 11:46:37 PST 
Comment on attachment 174807 [details]
Patch

thanks
Comment 6 WebKit Review Bot 2012-11-17 12:06:52 PST 
Comment on attachment 174807 [details]
Patch

Clearing flags on attachment: 174807

Committed r135050: <http://trac.webkit.org/changeset/135050>
Comment 7 WebKit Review Bot 2012-11-17 12:06:56 PST 
All reviewed patches have been landed.  Closing bug.