New version of compiler finds new inconsistencies. 1) DOMAgent.js:1285: actual parameter 1 of Object.defineProperty does not match formal parameter 2) ElementsPanel.js:81: Property domBreakpointsSidebarPane never defined on WebInspector 3) Script.js:152: actual parameter 4 of DebuggerAgent.setScriptSource does not match formal parameter
Created attachment 174359 [details] Patch
Comment on attachment 174359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174359&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:1284 > + for (var i = 0; i < touchEvents.length; ++i) { } around the block
Comment on attachment 174359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174359&action=review >> Source/WebCore/inspector/front-end/DOMAgent.js:1284 >> + for (var i = 0; i < touchEvents.length; ++i) > > { } around the block Fixed.
Created attachment 174364 [details] Patch
Comment on attachment 174364 [details] Patch Clearing flags on attachment: 174364 Committed r134751: <http://trac.webkit.org/changeset/134751>
All reviewed patches have been landed. Closing bug.
Comment on attachment 174364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174364&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:1285 > + for (var j = 0; j < recepients.length; ++j) { IMO, now you have more lines of code, and less readable code. BTW, I think JS compiler does not complain because it treats the "recepients" as "@type {?}", now? otherwise I don't see why the new version is more typed then the old one. And one more thing. "recepients" -> "recipients"