Bug 102338 - Remove CodeGenerator::StripModule
Summary: Remove CodeGenerator::StripModule
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 22:49 PST by Kentaro Hara
Modified: 2012-11-15 16:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.70 KB, patch)
2012-11-14 22:51 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (21.68 KB, patch)
2012-11-14 23:02 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-14 22:49:26 PST 
Now WebKit IDL files have no modules. (The Web IDL spec has no modules.) We can remove CodeGenerator::StripModule.

This might break some internal builds if the internal builds are still using modules. So I'll land it when I can stay on IRC.
Comment 1 Kentaro Hara 2012-11-14 22:51:21 PST 
Created attachment 174354 [details]
Patch
Comment 2 Early Warning System Bot 2012-11-14 22:57:50 PST 
Comment on attachment 174354 [details]
Patch

Attachment 174354 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14843452
Comment 3 EFL EWS Bot 2012-11-14 22:59:11 PST 
Comment on attachment 174354 [details]
Patch

Attachment 174354 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14846275
Comment 4 Early Warning System Bot 2012-11-14 23:00:44 PST 
Comment on attachment 174354 [details]
Patch

Attachment 174354 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14844374
Comment 5 Kentaro Hara 2012-11-14 23:02:15 PST 
Created attachment 174356 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-15 16:17:11 PST 
Comment on attachment 174356 [details]
Patch

Clearing flags on attachment: 174356

Committed r134849: <http://trac.webkit.org/changeset/134849>
Comment 7 WebKit Review Bot 2012-11-15 16:17:14 PST 
All reviewed patches have been landed.  Closing bug.