IndexedDB: remove setVersion from intversion-long-queue
Created attachment 174326 [details] Patch
Josh, could you take a look at this one also?
Comment on attachment 174326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174326&action=review lgtm with nits > LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:66 > + shouldBeNonNull("event.oldVersion"); Can you make this expect a specific version? > LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:99 > + debug("FIXME: Fire a versionchange event that has oldVersion and newVersion"); Isn't this already correct? If not, I'd expect a FAIL here (e.g. on the event type?)
Comment on attachment 174326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174326&action=review >> LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:66 >> + shouldBeNonNull("event.oldVersion"); > > Can you make this expect a specific version? Done >> LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:99 >> + debug("FIXME: Fire a versionchange event that has oldVersion and newVersion"); > > Isn't this already correct? If not, I'd expect a FAIL here (e.g. on the event type?) Oops, removed.
Created attachment 174515 [details] Patch
Tony, could you review this?
Comment on attachment 174515 [details] Patch Clearing flags on attachment: 174515 Committed r134844: <http://trac.webkit.org/changeset/134844>
All reviewed patches have been landed. Closing bug.