Bug 102319 - [chromium] Move allowWebGL query to WebFrameClient
Summary: [chromium] Move allowWebGL query to WebFrameClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 101826
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-14 19:30 PST by Kenneth Russell
Modified: 2012-11-15 10:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2012-11-14 19:39 PST, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-11-14 19:30:57 PST 
After offline discussion, the allowWebGL query added in https://bugs.webkit.org/show_bug.cgi?id=101826 needs to be moved from WebPermissionClient to WebFrameClient in order to keep its implementation in the content/ module and avoid polluting the content/ API.
Comment 1 Kenneth Russell 2012-11-14 19:39:53 PST 
Created attachment 174323 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-14 19:42:23 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-11-15 10:02:35 PST 
Comment on attachment 174323 [details]
Patch

I'm slightly hesitant to design the WebKit API around the higher-level abstractions in Chromium, but this change seems ok.
Comment 4 WebKit Review Bot 2012-11-15 10:34:05 PST 
Comment on attachment 174323 [details]
Patch

Clearing flags on attachment: 174323

Committed r134794: <http://trac.webkit.org/changeset/134794>
Comment 5 WebKit Review Bot 2012-11-15 10:34:09 PST 
All reviewed patches have been landed.  Closing bug.