Bug 102318 - IndexedDB: test conversion batch 6
Summary: IndexedDB: test conversion batch 6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 18:49 PST by David Grogan
Modified: 2012-11-15 13:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (22.12 KB, patch)
2012-11-14 18:51 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (22.28 KB, patch)
2012-11-15 12:31 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-11-14 18:49:47 PST 
IndexedDB: test conversion batch 6
Comment 1 David Grogan 2012-11-14 18:51:32 PST 
Created attachment 174316 [details]
Patch
Comment 2 David Grogan 2012-11-14 18:53:24 PST 
Josh, this is really just salvaging the remnants of a test.  intversion-and-setversion originally tested the interaction between those two but it's renamed intversion-upgrades and just does some basic intversion opens and upgrades.
Comment 3 David Grogan 2012-11-14 18:53:35 PST 
Oh, and could you take a look?
Comment 4 David Grogan 2012-11-14 20:00:22 PST 
Note to self: IndexedDBLayoutTest.IntVersionTests runs intversion-and-setversion, so change that before letting this roll into webkit.
Comment 5 Joshua Bell 2012-11-15 12:24:34 PST 
Comment on attachment 174316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174316&action=review

lgtm

> LayoutTests/storage/indexeddb/resources/intversion-upgrades.js:99
> +    evalAndLog("event.target.result.close()");

Just for completeness I'd toss in: 

evalAndLog("connection3 = event.target.result");
shouldBe("connection3.version", "2");
Comment 6 David Grogan 2012-11-15 12:31:22 PST 
Created attachment 174499 [details]
Patch
Comment 7 David Grogan 2012-11-15 12:31:49 PST 
Comment on attachment 174316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174316&action=review

>> LayoutTests/storage/indexeddb/resources/intversion-upgrades.js:99
>> +    evalAndLog("event.target.result.close()");
> 
> Just for completeness I'd toss in: 
> 
> evalAndLog("connection3 = event.target.result");
> shouldBe("connection3.version", "2");

Done.
Comment 8 David Grogan 2012-11-15 13:07:35 PST 
Tony, could you review this?
Comment 9 WebKit Review Bot 2012-11-15 13:35:19 PST 
Comment on attachment 174499 [details]
Patch

Clearing flags on attachment: 174499

Committed r134825: <http://trac.webkit.org/changeset/134825>
Comment 10 WebKit Review Bot 2012-11-15 13:35:22 PST 
All reviewed patches have been landed.  Closing bug.