RESOLVED FIXED 102318
IndexedDB: test conversion batch 6 
https://bugs.webkit.org/show_bug.cgi?id=102318
Summary IndexedDB: test conversion batch 6
David Grogan
Reported 2012-11-14 18:49:47 PST
IndexedDB: test conversion batch 6
Attachments
Patch (22.12 KB, patch)
2012-11-14 18:51 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (22.28 KB, patch)
2012-11-15 12:31 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-11-14 18:51:32 PST
Created attachment 174316 [details] Patch
David Grogan
Comment 2 2012-11-14 18:53:24 PST
Josh, this is really just salvaging the remnants of a test. intversion-and-setversion originally tested the interaction between those two but it's renamed intversion-upgrades and just does some basic intversion opens and upgrades.
David Grogan
Comment 3 2012-11-14 18:53:35 PST
Oh, and could you take a look?
David Grogan
Comment 4 2012-11-14 20:00:22 PST
Note to self: IndexedDBLayoutTest.IntVersionTests runs intversion-and-setversion, so change that before letting this roll into webkit.
Joshua Bell
Comment 5 2012-11-15 12:24:34 PST
Comment on attachment 174316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174316&action=review lgtm > LayoutTests/storage/indexeddb/resources/intversion-upgrades.js:99 > + evalAndLog("event.target.result.close()"); Just for completeness I'd toss in: evalAndLog("connection3 = event.target.result"); shouldBe("connection3.version", "2");
David Grogan
Comment 6 2012-11-15 12:31:22 PST
Created attachment 174499 [details] Patch
David Grogan
Comment 7 2012-11-15 12:31:49 PST
Comment on attachment 174316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174316&action=review >> LayoutTests/storage/indexeddb/resources/intversion-upgrades.js:99 >> + evalAndLog("event.target.result.close()"); > > Just for completeness I'd toss in: > > evalAndLog("connection3 = event.target.result"); > shouldBe("connection3.version", "2"); Done.
David Grogan
Comment 8 2012-11-15 13:07:35 PST
Tony, could you review this?
WebKit Review Bot
Comment 9 2012-11-15 13:35:19 PST
Comment on attachment 174499 [details] Patch Clearing flags on attachment: 174499 Committed r134825: <http://trac.webkit.org/changeset/134825>
WebKit Review Bot
Comment 10 2012-11-15 13:35:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.