RESOLVED FIXED 102312
[V8] Kill $implClassName from CodeGeneratorV8.pm 
https://bugs.webkit.org/show_bug.cgi?id=102312
Summary [V8] Kill $implClassName from CodeGeneratorV8.pm
Kentaro Hara
Reported 2012-11-14 18:09:06 PST
$implClassName and $interfaceName are the same. Sometimes we are passing both $implClassName and $interfaceName to subroutines. We can kill $implClassName.
Attachments
Patch (44.04 KB, patch)
2012-11-14 18:09 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (44.00 KB, patch)
2012-11-14 19:16 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-14 18:09:57 PST
Created attachment 174308 [details] Patch
Adam Barth
Comment 2 2012-11-14 18:50:57 PST
Comment on attachment 174308 [details] Patch They're not different in the case of the [InterfaceName=Window] IDL attribute?
Kentaro Hara
Comment 3 2012-11-14 19:01:04 PST
(In reply to comment #2) > (From update of attachment 174308 [details]) > They're not different in the case of the [InterfaceName=Window] IDL attribute? It's managed by $visibleInterfaceName. The current situation is: my $interfaceName = $dataNode->name; my $implClassName = $dataNode->name; my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($dataNode); ...; # Use $interfaceName and $implClassName interchangeably.
Adam Barth
Comment 4 2012-11-14 19:08:58 PST
Comment on attachment 174308 [details] Patch ok
Kentaro Hara
Comment 5 2012-11-14 19:16:46 PST
Created attachment 174321 [details] patch for landing
WebKit Review Bot
Comment 6 2012-11-14 19:46:11 PST
Comment on attachment 174321 [details] patch for landing Clearing flags on attachment: 174321 Committed r134730: <http://trac.webkit.org/changeset/134730>
WebKit Review Bot
Comment 7 2012-11-14 19:46:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.