Bug 102312 - [V8] Kill $implClassName from CodeGeneratorV8.pm
Summary: [V8] Kill $implClassName from CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 18:09 PST by Kentaro Hara
Modified: 2012-11-14 19:46 PST (History)
2 users (show)

See Also:


Attachments
Patch (44.04 KB, patch)
2012-11-14 18:09 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for landing (44.00 KB, patch)
2012-11-14 19:16 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-14 18:09:06 PST
$implClassName and $interfaceName are the same. Sometimes we are passing both $implClassName and $interfaceName to subroutines. We can kill $implClassName.
Comment 1 Kentaro Hara 2012-11-14 18:09:57 PST
Created attachment 174308 [details]
Patch
Comment 2 Adam Barth 2012-11-14 18:50:57 PST
Comment on attachment 174308 [details]
Patch

They're not different in the case of the [InterfaceName=Window] IDL attribute?
Comment 3 Kentaro Hara 2012-11-14 19:01:04 PST
(In reply to comment #2)
> (From update of attachment 174308 [details])
> They're not different in the case of the [InterfaceName=Window] IDL attribute?

It's managed by $visibleInterfaceName. The current situation is:

my $interfaceName = $dataNode->name;
my $implClassName = $dataNode->name;
my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($dataNode);

...; # Use $interfaceName and $implClassName interchangeably.
Comment 4 Adam Barth 2012-11-14 19:08:58 PST
Comment on attachment 174308 [details]
Patch

ok
Comment 5 Kentaro Hara 2012-11-14 19:16:46 PST
Created attachment 174321 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-11-14 19:46:11 PST
Comment on attachment 174321 [details]
patch for landing

Clearing flags on attachment: 174321

Committed r134730: <http://trac.webkit.org/changeset/134730>
Comment 7 WebKit Review Bot 2012-11-14 19:46:14 PST
All reviewed patches have been landed.  Closing bug.