RESOLVED FIXED 102305
biquadfilternode-basic.html test should cover default value of frequency, Q and gain. 
https://bugs.webkit.org/show_bug.cgi?id=102305
Summary biquadfilternode-basic.html test should cover default value of frequency, Q a...
Li Yin
Reported 2012-11-14 17:39:48 PST
According yo Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#BiquadFilterNode The default values of frequency, Q and gain are clearly specified, we should have related sub test to over them.
Attachments
Patch (2.87 KB, patch)
2012-11-14 17:43 PST, Li Yin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Li Yin
Comment 1 2012-11-14 17:43:27 PST
Created attachment 174299 [details] Patch
Chris Rogers
Comment 2 2012-11-16 10:32:12 PST
Comment on attachment 174299 [details] Patch thanks
WebKit Review Bot
Comment 3 2012-11-16 10:42:09 PST
Comment on attachment 174299 [details] Patch Rejecting attachment 174299 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: angeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] Copy linux theme related files to default When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14872229
Li Yin
Comment 4 2012-11-16 21:59:55 PST
The conflict is not resulted from this patch, since the conflict came from Source/WebCore/ChangeLog and Source/Platform/ChangeLog, and there is no change to these files in this patch. Let me mark cq? again.
WebKit Review Bot
Comment 5 2012-11-17 11:59:24 PST
Comment on attachment 174299 [details] Patch Clearing flags on attachment: 174299 Committed r135049: <http://trac.webkit.org/changeset/135049>
WebKit Review Bot
Comment 6 2012-11-17 11:59:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.