Bug 102302 - Fix Windows exports for TestWebKit
Summary: Fix Windows exports for TestWebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks: 96818
  Show dependency tree / graph
 
Reported: 2012-11-14 16:59 PST by Alec Flett
Modified: 2012-11-15 00:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2012-11-14 17:00 PST, Alec Flett 		no flags Details | Formatted Diff | Diff
Patch for landing (4.18 KB, patch)
2012-11-14 17:02 PST, Alec Flett 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-11-14 16:59:57 PST 
Fix Windows exports for TestWebKit
Comment 1 Alec Flett 2012-11-14 17:00:33 PST 
Created attachment 174293 [details]
Patch
Comment 2 Alec Flett 2012-11-14 17:02:03 PST 
Created attachment 174295 [details]
Patch for landing
Comment 3 WebKit Review Bot 2012-11-14 17:38:31 PST 
Comment on attachment 174295 [details]
Patch for landing

Clearing flags on attachment: 174295

Committed r134703: <http://trac.webkit.org/changeset/134703>
Comment 4 WebKit Review Bot 2012-11-14 17:38:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2012-11-14 17:58:27 PST 
How is a change to the WebKit2 def file supposed to fix a build failure in the JavaScriptCore library?  It's way before WebKit2 comes into play.
Comment 6 Brent Fulgham 2012-11-14 18:15:17 PST 
Landed a fix for the JavaScriptCore build issue in r134715.  Will wait to see if test cases fail, or if the WebKit2.def changes were enough to resolve that issue.
Comment 7 Brent Fulgham 2012-11-14 18:19:23 PST 
Landed corresponding fix to WinCairo version of def file in r134716.

That should get all the Windows bots building again.
Comment 8 Roger Fong 2012-11-14 19:19:08 PST 
all of the windows bots are still red. 
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/39494
Comment 9 Brent Fulgham 2012-11-14 21:22:19 PST 
Alec fixed it; there was one more export missing from WebKit2.def/WebKit2CFLite.def.  Bots are now green.