RESOLVED FIXED 102302
Fix Windows exports for TestWebKit 
https://bugs.webkit.org/show_bug.cgi?id=102302
Summary Fix Windows exports for TestWebKit
Alec Flett
Reported 2012-11-14 16:59:57 PST
Fix Windows exports for TestWebKit
Attachments
Patch (4.17 KB, patch)
2012-11-14 17:00 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.18 KB, patch)
2012-11-14 17:02 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-11-14 17:00:33 PST
Created attachment 174293 [details] Patch
Alec Flett
Comment 2 2012-11-14 17:02:03 PST
Created attachment 174295 [details] Patch for landing
WebKit Review Bot
Comment 3 2012-11-14 17:38:31 PST
Comment on attachment 174295 [details] Patch for landing Clearing flags on attachment: 174295 Committed r134703: <http://trac.webkit.org/changeset/134703>
WebKit Review Bot
Comment 4 2012-11-14 17:38:34 PST
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2012-11-14 17:58:27 PST
How is a change to the WebKit2 def file supposed to fix a build failure in the JavaScriptCore library? It's way before WebKit2 comes into play.
Brent Fulgham
Comment 6 2012-11-14 18:15:17 PST
Landed a fix for the JavaScriptCore build issue in r134715. Will wait to see if test cases fail, or if the WebKit2.def changes were enough to resolve that issue.
Brent Fulgham
Comment 7 2012-11-14 18:19:23 PST
Landed corresponding fix to WinCairo version of def file in r134716. That should get all the Windows bots building again.
Roger Fong
Comment 8 2012-11-14 19:19:08 PST
all of the windows bots are still red. http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/39494
Brent Fulgham
Comment 9 2012-11-14 21:22:19 PST
Alec fixed it; there was one more export missing from WebKit2.def/WebKit2CFLite.def. Bots are now green.
Note You need to log in before you can comment on or make changes to this bug.