WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
102290
IndexedDB: Ensure structured clone test exercises serialization/deserialization
https://bugs.webkit.org/show_bug.cgi?id=102290
Summary
IndexedDB: Ensure structured clone test exercises serialization/deserialization
Joshua Bell
Reported
2012-11-14 14:57:51 PST
LayoutTests/storage/indexeddb/structured-clone.html has: evalAndLog("store = db.createObjectStore('storeName')"); debug("This index is not used, but evaluating key path on each put() call will exercise (de)serialization:"); evalAndLog("store.createIndex('indexName', 'dummyKeyPath')"); ... but now that we compute index keys in the front end using ScriptValue we do not necessarily serialize/deserialize. We should update the test to ensure values can be stored and fetched back out again.
Attachments
Add attachment
proposed patch, testcase, etc.
Alec Flett
Comment 1
2012-11-14 16:01:55 PST
I feel like all of our existing tests cover whatever we'd want to cover here?
Joshua Bell
Comment 2
2012-11-14 16:07:28 PST
Actually, in reviewing the structured-clone.html test, we do store/retrieve the values, so it's good enough IMHO.
Joshua Bell
Comment 3
2012-11-14 16:08:03 PST
(In reply to
comment #1
)
> I feel like all of our existing tests cover whatever we'd want to cover here?
I'd thought we only e.g, stored them to make sure they didn't crash, and relied on index computation to deserialize/re-serialize. My bad.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug