Bug 102289 - Cleanup BasicShape blending check
Summary: Cleanup BasicShape blending check
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
Depends on:
Blocks: 95389
  Show dependency treegraph
Reported: 2012-11-14 14:56 PST by Dirk Schulze
Modified: 2012-11-14 15:27 PST (History)
3 users (show)

See Also:

Patch (4.28 KB, patch)
2012-11-14 15:18 PST, Dirk Schulze
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-11-14 14:56:56 PST
We have the same checks if two BasicShape objects can be blended twice. Refactor the code and add a canBlend method in BasicShape that combined the check.
Comment 1 Dirk Schulze 2012-11-14 15:18:27 PST
Created attachment 174268 [details]
Comment 2 Eric Seidel (no email) 2012-11-14 15:25:13 PST
Comment on attachment 174268 [details]

The double-negatives are a bit confusing.  But this looks right.
Comment 3 Dirk Schulze 2012-11-14 15:27:53 PST
Committed r134679: <http://trac.webkit.org/changeset/134679>