RESOLVED FIXED 102286
String::append() should handle two 8 bit strings without converting both to 16 bits 
https://bugs.webkit.org/show_bug.cgi?id=102286
Summary String::append() should handle two 8 bit strings without converting both to 1...
Michael Saboff
Reported 2012-11-14 14:33:54 PST
String::append() creates the new concatenated string by calling characters() on both the "this" and argument strings. Given that most strings are 8 bit, both strings will be upconverted to 16 bits and the result will also be 16 bits. This can "leak" 16 bit strings to the rest of WebKit. Instead we should check to see if both strings are 8 bit, we should use the string data directly and create a new 8 bit string.
Attachments
Patch (1.98 KB, patch)
2012-11-14 14:42 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-11-14 14:42:10 PST
Created attachment 174265 [details] Patch
WebKit Review Bot
Comment 2 2012-11-14 15:05:17 PST
Comment on attachment 174265 [details] Patch Clearing flags on attachment: 174265 Committed r134677: <http://trac.webkit.org/changeset/134677>
WebKit Review Bot
Comment 3 2012-11-14 15:05:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.