Bug 102280 - [BlackBerry] Leave surface resizing to the client
Summary: [BlackBerry] Leave surface resizing to the client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 13:51 PST by Jakob Petsovits
Modified: 2012-11-15 09:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.54 KB, patch)
2012-11-14 14:22 PST, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-11-14 13:51:16 PST 
Now that we always blit on the user interface thread and use the client's userInterfaceViewportAccessor() to determine the destination rectangle for blitting, changing the viewport size does not affect the window or target surface directly. The only way that blitted output is affected is through layout, scroll position or scale changes. None of these require us to synchronize with the UI thread to resize its target surface.

The commit below simplifies setViewportSize() and removes a blocking message dispatch by simply offloading all surface resizing responsibilities to the client. This is safer, cleaner and easier.
Comment 1 Jakob Petsovits 2012-11-14 14:22:04 PST 
Created attachment 174262 [details]
Patch
Comment 2 Adam Treat 2012-11-15 08:44:22 PST 
Comment on attachment 174262 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2012-11-15 09:03:07 PST 
Comment on attachment 174262 [details]
Patch

Clearing flags on attachment: 174262

Committed r134782: <http://trac.webkit.org/changeset/134782>
Comment 4 WebKit Review Bot 2012-11-15 09:03:11 PST 
All reviewed patches have been landed.  Closing bug.