Bug 102259 - Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader
Summary: Move loading responsibility out of WebResourceLoadScheduler into a new WebRes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 98537
  Show dependency tree / graph
 
Reported: 2012-11-14 11:32 PST by Brady Eidson
Modified: 2012-11-14 15:59 PST (History)
3 users (show)

See Also:

Attachments
Patch 1, v1 (17.67 KB, patch)
2012-11-14 11:38 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Patch 2, v1 (34.87 KB, patch)
2012-11-14 14:23 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-11-14 11:32:55 PST 
Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader

Per the FIXME in WebResourceLoadScheduler.h, it's taken it too many responsibilities that don't belong to it.

We should make a WebResourceLoader that is an intermediary proxy between WebCore and the NetworkProcess.
- It will directly represent a single WebCore::ResourceLoader and be able to deliver loading callbacks to it
- It will be directly message-able from the NetworkProcess without going through the WebResourceLoadScheduler

I'll resolve this bug in 2 separate patches for ease of review.
Comment 1 Brady Eidson 2012-11-14 11:38:44 PST 
Created attachment 174212 [details]
Patch 1, v1

This gets a new class into the build.

After this lands I'll change the messaging to stop using WebResourceLoadScheduler and go directly to this new class.
Comment 2 Brady Eidson 2012-11-14 11:44:22 PST 
Part 1 landed in http://trac.webkit.org/changeset/134640
Comment 3 Brady Eidson 2012-11-14 14:23:51 PST 
Created attachment 174263 [details]
Patch 2, v1

Switch the messaging model over to messaging WebResourceLoaders directly.
Comment 4 Brady Eidson 2012-11-14 15:59:52 PST 
http://trac.webkit.org/changeset/134687