Bug 102255 - IndexedDB: Remove magic numbers in record comparator, handle missing case
Summary: IndexedDB: Remove magic numbers in record comparator, handle missing case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks: 102243
  Show dependency treegraph
 
Reported: 2012-11-14 11:13 PST by Joshua Bell
Modified: 2012-11-14 15:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.21 KB, patch)
2012-11-14 11:36 PST, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-11-14 11:13:27 PST
IndexedDB: Remove magic numbers in record comparator, handle missing case
Comment 1 Joshua Bell 2012-11-14 11:36:54 PST
Created attachment 174210 [details]
Patch
Comment 2 Joshua Bell 2012-11-14 11:37:32 PST
Comment on attachment 174210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174210&action=review

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:-896
> -        // FIXME: Assert not reached here?

This will fall through to the ASSERT at the end of the function, as the other cases do.
Comment 3 Joshua Bell 2012-11-14 11:38:07 PST
alecflett@, dgrogan@ - please take a look?
Comment 4 Alec Flett 2012-11-14 14:02:43 PST
Comment on attachment 174210 [details]
Patch

lgtm, wondering if this is worth merging into M23/M24?
Comment 5 Joshua Bell 2012-11-14 14:05:31 PST
tony@ - r?
Comment 6 WebKit Review Bot 2012-11-14 15:29:27 PST
Comment on attachment 174210 [details]
Patch

Clearing flags on attachment: 174210

Committed r134680: <http://trac.webkit.org/changeset/134680>
Comment 7 WebKit Review Bot 2012-11-14 15:29:30 PST
All reviewed patches have been landed.  Closing bug.