Bug 102251 - [Mac] Implement WTR --no-timeout-at-all option
Summary: [Mac] Implement WTR --no-timeout-at-all option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 10:56 PST by Alexey Proskuryakov
Modified: 2012-11-15 10:13 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (1.78 KB, patch)
2012-11-14 11:06 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-11-14 10:56:55 PST 
Currently, WTR just crashes when it's used. A FIXME says that the option is needed for performance testing, but it would also be good if WTR didn't die while being debugged.
Comment 1 Alexey Proskuryakov 2012-11-14 11:06:56 PST 
Created attachment 174204 [details]
proposed patch
Comment 2 Build Bot 2012-11-15 04:53:24 PST 
Comment on attachment 174204 [details]
proposed patch

Attachment 174204 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14858017

New failing tests:
inspector-protocol/nmi-webaudio.html
Comment 3 Alexey Proskuryakov 2012-11-15 08:32:07 PST 
Comment on attachment 174204 [details]
proposed patch

Test failure is obviously unrelated.
Comment 4 WebKit Review Bot 2012-11-15 08:51:31 PST 
Comment on attachment 174204 [details]
proposed patch

Clearing flags on attachment: 174204

Committed r134780: <http://trac.webkit.org/changeset/134780>
Comment 5 WebKit Review Bot 2012-11-15 08:51:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brady Eidson 2012-11-15 09:20:06 PST 
Comment on attachment 174204 [details]
proposed patch

Is m_noTimeout equal to zero?  If so, can the conditional be (timeout != m_noTimeout) ?
Comment 7 Brady Eidson 2012-11-15 09:20:26 PST 
Whoops, didn't mean to remark for review.
Comment 8 Alexey Proskuryakov 2012-11-15 10:13:26 PST 
> Is m_noTimeout equal to zero?  If so, can the conditional be (timeout != m_noTimeout) ?

m_noTimeout is -1, but I don't see any practical difference between these checks. No non-positive timeout ever makes sense, because WTR will immediately die failing to handle any messages to WebProcess.