RESOLVED FIXED 102251
[Mac] Implement WTR --no-timeout-at-all option 
https://bugs.webkit.org/show_bug.cgi?id=102251
Summary [Mac] Implement WTR --no-timeout-at-all option
Alexey Proskuryakov
Reported 2012-11-14 10:56:55 PST
Currently, WTR just crashes when it's used. A FIXME says that the option is needed for performance testing, but it would also be good if WTR didn't die while being debugged.
Attachments
proposed patch (1.78 KB, patch)
2012-11-14 11:06 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-11-14 11:06:56 PST
Created attachment 174204 [details] proposed patch
Build Bot
Comment 2 2012-11-15 04:53:24 PST
Comment on attachment 174204 [details] proposed patch Attachment 174204 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14858017 New failing tests: inspector-protocol/nmi-webaudio.html
Alexey Proskuryakov
Comment 3 2012-11-15 08:32:07 PST
Comment on attachment 174204 [details] proposed patch Test failure is obviously unrelated.
WebKit Review Bot
Comment 4 2012-11-15 08:51:31 PST
Comment on attachment 174204 [details] proposed patch Clearing flags on attachment: 174204 Committed r134780: <http://trac.webkit.org/changeset/134780>
WebKit Review Bot
Comment 5 2012-11-15 08:51:35 PST
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 6 2012-11-15 09:20:06 PST
Comment on attachment 174204 [details] proposed patch Is m_noTimeout equal to zero? If so, can the conditional be (timeout != m_noTimeout) ?
Brady Eidson
Comment 7 2012-11-15 09:20:26 PST
Whoops, didn't mean to remark for review.
Alexey Proskuryakov
Comment 8 2012-11-15 10:13:26 PST
> Is m_noTimeout equal to zero? If so, can the conditional be (timeout != m_noTimeout) ? m_noTimeout is -1, but I don't see any practical difference between these checks. No non-positive timeout ever makes sense, because WTR will immediately die failing to handle any messages to WebProcess.
Note You need to log in before you can comment on or make changes to this bug.