Bug 102246 – [chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sadrul Habib Chowdhury]

[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled.

[Sadrul Habib Chowdhury]

Created attachment 174185 [details]
Patch

[Sadrul Habib Chowdhury]

Hi! This is the corresponding change for chromium patch http://codereview.chromium.org/11365238/

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 174185 [details]
Patch

R=me, but with this setup I think you're going to have a hard time landing without breaking one build or another.  Typically a transition like this is done by adding a #define to guard the new API and #ifdefing on that in the chromium side.

[WebKit Review Bot]

Comment on attachment 174185 [details]
Patch

Attachment 174185 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14824813

[Peter Beverloo (cr-android ews)]

Comment on attachment 174185 [details]
Patch

Attachment 174185 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14831623

[Sadrul Habib Chowdhury]

Created attachment 174421 [details]
same patch

The chromium CL this depends on has now been gardened for webkit. It should be safe to land now. Re-uploading the same patch so I can send it to EWS.

[Sadrul Habib Chowdhury]

Comment on attachment 174421 [details]
same patch

The chromium build is green from EWS. Requesting cq

[WebKit Review Bot]

Comment on attachment 174421 [details]
same patch

Rejecting attachment 174421 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14845539

[Dana Jansens]

You need to webkit-patch land-safely to stick james' name in the changelog, or do it by hand and reupload.

[Sadrul Habib Chowdhury]

Created attachment 174476 [details]
patch

Uploading the same patch with correct 'Reviewed By' in ChangeLog. Thanks!

[WebKit Review Bot]

Comment on attachment 174476 [details]
patch

Clearing flags on attachment: 174476

Committed r134809: <http://trac.webkit.org/changeset/134809>