RESOLVED FIXED 102245
Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
https://bugs.webkit.org/show_bug.cgi?id=102245
Summary Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer...
Peter Beverloo
Reported Wednesday, November 14, 2012 5:56:22 PM UTC
Duplicating most of the logic for running arbitrary test-suites is not worth the effort, especially given that Chromium already has an excellent testing framework. This change is dependent on the Chromium-side change which prepares it for WebKit usage, but changes there (in the argument usage) should be minimal. https://codereview.chromium.org/11312239/ Patch upcoming..
Attachments
Patch (2.95 KB, patch)
2012-11-14 10:19 PST, Peter Beverloo
no flags
Peter Beverloo
Comment 1 Wednesday, November 14, 2012 6:19:08 PM UTC
Tony Chang
Comment 2 Wednesday, November 14, 2012 7:21:00 PM UTC
Comment on attachment 174193 [details] Patch Do we need to wait for the chromium side to land and roll Source/WebKit/chromium/DEPS first?
Peter Beverloo
Comment 3 Wednesday, November 14, 2012 7:36:59 PM UTC
Comment on attachment 174193 [details] Patch It doesn't really matter, it's broken already. I'll pull in DEPS later in the week. Thanks for the review!
Peter Beverloo
Comment 4 Friday, November 16, 2012 11:23:49 AM UTC
Peter Beverloo
Comment 5 Friday, November 16, 2012 11:32:52 AM UTC
Comment on attachment 174193 [details] Patch I rolled DEPS earlier today and landed this manually (as it's Android only and all the try-bots are green). Thanks again!
Note You need to log in before you can comment on or make changes to this bug.