Otherwise we hit memory leaks.
Created attachment 174167 [details] Patch
Comment on attachment 174167 [details] Patch Attachment 174167 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14834373 New failing tests: http/tests/inspector/appcache/appcache-iframe-manifests.html http/tests/inspector/injected-script-for-origin.html http/tests/inspector/extensions-network-redirect.html http/tests/inspector/change-iframe-src.html http/tests/inspector/modify-cross-domain-rule.html http/tests/inspector/resource-har-conversion.html http/tests/inspector/console-resource-errors.html http/tests/inspector/filesystem/delete-entry.html http/tests/inspector/extensions-headers.html http/tests/inspector-enabled/injected-script-discard.html http/tests/inspector/console-cross-origin-iframe-logging.html http/tests/inspector/appcache/appcache-swap.html http/tests/inspector/extensions-useragent.html http/tests/inspector-enabled/dynamic-scripts.html http/tests/inspector/console-cd-completions.html http/tests/inspector/compiler-script-mapping.html http/tests/inspector/compiler-source-mapping-debug.html http/tests/inspector/filesystem/directory-tree.html http/tests/inspector/web-socket-frame-error.html http/tests/inspector/console-xhr-logging.html http/tests/inspector/console-xhr-logging-async.html http/tests/inspector/console-cd.html http/tests/inspector/resource-har-headers.html http/tests/inspector/network-preflight-options.html http/tests/inspector/inspect-iframe-from-different-domain.html http/tests/inspector-enabled/console-log-before-frame-navigation.html http/tests/inspector-enabled/dom-storage-open.html http/tests/inspector/resource-parameters.html http/tests/inspector-enabled/database-open.html http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
Created attachment 174175 [details] Patch
Comment on attachment 174175 [details] Patch Attachment 174175 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14833351 New failing tests: http/tests/inspector/appcache/appcache-iframe-manifests.html http/tests/inspector/injected-script-for-origin.html http/tests/inspector/extensions-network-redirect.html http/tests/inspector/change-iframe-src.html http/tests/inspector/modify-cross-domain-rule.html http/tests/inspector/resource-har-conversion.html http/tests/inspector/console-resource-errors.html http/tests/inspector/filesystem/delete-entry.html http/tests/inspector/extensions-headers.html http/tests/inspector-enabled/injected-script-discard.html http/tests/inspector/console-cross-origin-iframe-logging.html http/tests/inspector/appcache/appcache-swap.html http/tests/inspector/extensions-useragent.html http/tests/inspector-enabled/dynamic-scripts.html http/tests/inspector/console-cd-completions.html http/tests/inspector/compiler-script-mapping.html http/tests/inspector/compiler-source-mapping-debug.html http/tests/inspector/filesystem/directory-tree.html http/tests/inspector/web-socket-frame-error.html http/tests/inspector/console-xhr-logging.html http/tests/inspector/console-xhr-logging-async.html http/tests/inspector/console-cd.html http/tests/inspector/resource-har-headers.html http/tests/inspector/network-preflight-options.html http/tests/inspector/inspect-iframe-from-different-domain.html http/tests/inspector-enabled/console-log-before-frame-navigation.html http/tests/inspector-enabled/dom-storage-open.html http/tests/inspector/resource-parameters.html http/tests/inspector-enabled/database-open.html http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
Committed r134627: <http://trac.webkit.org/changeset/134627>
(In reply to comment #5) > Committed r134627: <http://trac.webkit.org/changeset/134627> It broke all inspector test on Qt - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r134629%20%2845085%29/results.html +main frame - has 1 onunload handler(s) Could you check it please?
> +main frame - has 1 onunload handler(s) > > Could you check it please? Looking.
(In reply to comment #7) > > +main frame - has 1 onunload handler(s) > > > > Could you check it please? > > Looking. CODE: if (!window.testRunner) { Causes new compiler warning: "testRunner" is not defined.
Fix landed in http://trac.webkit.org/changeset/134745