Bug 102238 - [BlackBerry] Add FocusBased context node detection strategy
Summary: [BlackBerry] Add FocusBased context node detection strategy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 08:20 PST by Andy Chen
Modified: 2012-11-14 10:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2012-11-14 10:10 PST, Andy Chen 		no flags Details | Formatted Diff | Diff
Patch (4.00 KB, patch)
2012-11-14 10:19 PST, Andy Chen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Chen 2012-11-14 08:20:32 PST 
If last fat finger result is invalid, we need to return current focus element as context node, because when user tap on selection overlay, there is not touch event sent to webkit.
Comment 1 Andy Chen 2012-11-14 10:10:41 PST 
Created attachment 174187 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-14 10:13:11 PST 
Attachment 174187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/blackberry/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andy Chen 2012-11-14 10:19:57 PST 
Created attachment 174194 [details]
Patch
Comment 4 Rob Buis 2012-11-14 10:21:48 PST 
Comment on attachment 174194 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-11-14 10:38:29 PST 
Comment on attachment 174194 [details]
Patch

Clearing flags on attachment: 174194

Committed r134624: <http://trac.webkit.org/changeset/134624>
Comment 6 WebKit Review Bot 2012-11-14 10:38:32 PST 
All reviewed patches have been landed.  Closing bug.