We were using node-relative offsets which do not work correctly with respect to IMF in content editable since a new node is created with every new line.
Created attachment 174159 [details] Patch
Attachment 174159 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:762: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:763: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 174159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174159&action=review Looks good but style errors need to be fixed. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:759 > + VisiblePosition caretPosition = m_currentFocusElement->document()->frame()->selection()->selection().visibleStart(); Scary. Also selection().selection() looks weird. >> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:763 >> + if (!rangeSelection) > > Omit int when using unsigned [runtime/unsigned] [1] Style queue bug? I assume it means the unsigned int below.... This is the second time in a week we are hitting style queue problems. Doesn't it like our IMF code? :) > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:767 > + unsigned int length = 0; I think the warnings are about these lines.
Created attachment 174166 [details] Patch
Comment on attachment 174166 [details] Patch Looks good.
Comment on attachment 174166 [details] Patch Clearing flags on attachment: 174166 Committed r134616: <http://trac.webkit.org/changeset/134616>
All reviewed patches have been landed. Closing bug.