Bug 102227 - Fix the MIPS build after r134332
Summary: Fix the MIPS build after r134332
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 101909
  Show dependency tree / graph
 
Reported: 2012-11-14 06:52 PST by Csaba Osztrogonác
Modified: 2012-11-14 07:26 PST (History)
4 users (show)

See Also:

Attachments
speculative fix (1.89 KB, patch)
2012-11-14 07:04 PST, Peter Gal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-11-14 06:52:54 PST 
In file included from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch(JSC::CodeLocationDataLabelPtr)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146: error: 'startOfPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler'
In file included from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Address, void*)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:159: error: 'revertJumpReplacementToPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler'
make[2]: *** [obj/release/bytecode/CallLinkInfo.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:46:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch(JSC::CodeLocationDataLabelPtr)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146: error: 'startOfPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler'
In file included from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:46:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Address, void*)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:159: error: 'revertJumpReplacementToPatchableBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler'
make[2]: *** [obj/release/bytecode/CodeBlock.o] Error 1


http://trac.webkit.org/changeset/134383 is a similar fix for ARM traditional
(and http://trac.webkit.org/changeset/134603 is the warning fix)
Comment 1 Peter Gal 2012-11-14 06:56:31 PST 
ohh... okay... will do it in a jiffy
Comment 2 Peter Gal 2012-11-14 07:04:53 PST 
Created attachment 174150 [details]
speculative fix

This should get rid of the compile fail.
Comment 3 Csaba Osztrogonác 2012-11-14 07:08:02 PST 
Comment on attachment 174150 [details]
speculative fix

LGTM, r=me.
Comment 4 WebKit Review Bot 2012-11-14 07:25:58 PST 
Comment on attachment 174150 [details]
speculative fix

Clearing flags on attachment: 174150

Committed r134608: <http://trac.webkit.org/changeset/134608>
Comment 5 WebKit Review Bot 2012-11-14 07:26:01 PST 
All reviewed patches have been landed.  Closing bug.