Bug 102210 - Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart
Summary: Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 04:13 PST by Alexander Pavlov (apavlov)
Modified: 2012-11-28 10:02 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.26 KB, patch)
2012-11-21 22:34 PST, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2012-11-23 00:38 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (5.23 KB, patch)
2012-11-23 04:28 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-11-14 04:13:32 PST 
The checkbox changes should take effect in the real time.
Comment 1 eustas.bug 2012-11-21 22:34:29 PST 
Created attachment 175590 [details]
Patch
Comment 2 Pavel Feldman 2012-11-22 12:24:47 PST 
Comment on attachment 175590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:138
> +    this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread;

I would check for capability first.

> Source/WebCore/inspector/front-end/TimelinePanel.js:160
> +        var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread;

I don't think you need a capability check here.
Comment 3 Eugene Klyuchnikov 2012-11-23 00:27:32 PST 
Comment on attachment 175590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review

>> Source/WebCore/inspector/front-end/TimelinePanel.js:138
>> +    this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread;
> 
> I would check for capability first.

Done.

>> Source/WebCore/inspector/front-end/TimelinePanel.js:160
>> +        var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread;
> 
> I don't think you need a capability check here.

Done
Comment 4 Eugene Klyuchnikov 2012-11-23 00:38:18 PST 
Created attachment 175746 [details]
Patch
Comment 5 Pavel Feldman 2012-11-23 01:39:38 PST 
Comment on attachment 175746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:159
> +    _showCpuOnTimelineRulerChanged: function() {

{ on the next line
Comment 6 Eugene Klyuchnikov 2012-11-23 04:27:56 PST 
Comment on attachment 175746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review

>> Source/WebCore/inspector/front-end/TimelinePanel.js:159
>> +    _showCpuOnTimelineRulerChanged: function() {
> 
> { on the next line

fixed
Comment 7 Eugene Klyuchnikov 2012-11-23 04:28:54 PST 
Created attachment 175776 [details]
Patch
Comment 8 Andrey Kosyakov 2012-11-27 17:44:16 PST 
Committed r135959: <http://trac.webkit.org/changeset/135959>