RESOLVED FIXED 102210
Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart 
https://bugs.webkit.org/show_bug.cgi?id=102210
Summary Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox ...
Alexander Pavlov (apavlov)
Reported 2012-11-14 04:13:32 PST
The checkbox changes should take effect in the real time.
Attachments
Patch (5.26 KB, patch)
2012-11-21 22:34 PST, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (5.22 KB, patch)
2012-11-23 00:38 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.23 KB, patch)
2012-11-23 04:28 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-11-21 22:34:29 PST
Created attachment 175590 [details] Patch
Pavel Feldman
Comment 2 2012-11-22 12:24:47 PST
Comment on attachment 175590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:138 > + this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; I would check for capability first. > Source/WebCore/inspector/front-end/TimelinePanel.js:160 > + var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; I don't think you need a capability check here.
Eugene Klyuchnikov
Comment 3 2012-11-23 00:27:32 PST
Comment on attachment 175590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:138 >> + this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; > > I would check for capability first. Done. >> Source/WebCore/inspector/front-end/TimelinePanel.js:160 >> + var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; > > I don't think you need a capability check here. Done
Eugene Klyuchnikov
Comment 4 2012-11-23 00:38:18 PST
Created attachment 175746 [details] Patch
Pavel Feldman
Comment 5 2012-11-23 01:39:38 PST
Comment on attachment 175746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:159 > + _showCpuOnTimelineRulerChanged: function() { { on the next line
Eugene Klyuchnikov
Comment 6 2012-11-23 04:27:56 PST
Comment on attachment 175746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:159 >> + _showCpuOnTimelineRulerChanged: function() { > > { on the next line fixed
Eugene Klyuchnikov
Comment 7 2012-11-23 04:28:54 PST
Created attachment 175776 [details] Patch
Andrey Kosyakov
Comment 8 2012-11-27 17:44:16 PST
Committed r135959: <http://trac.webkit.org/changeset/135959>
Note You need to log in before you can comment on or make changes to this bug.